Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1561193002: [promise] Test IsPromise() early in Promise.prototype.then() (Closed)

Created:
4 years, 11 months ago by caitp (gmail)
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promise] Test IsPromise() early in Promise.prototype.then() Addresses TODO by Dan --- simply by moving the check and exception earlier in the function, before calling NewPromiseCapability() or loading the constructor. BUG=v8:4633 LOG=N R=adamk@chromium.org, littledan@chromium.org, cbruni@chromium.org Fixes 'test262/built-ins/Promise/prototype/then/context-check-on-entry' Committed: https://crrev.com/6cd8535c3b369cf07b4c0eae8075820f1c229df5 Cr-Commit-Position: refs/heads/master@{#33137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M src/js/promise.js View 1 chunk +6 lines, -6 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
caitp (gmail)
another quick fix, PTAL
4 years, 11 months ago (2016-01-06 16:52:49 UTC) #1
Dan Ehrenberg
lgtm
4 years, 11 months ago (2016-01-06 17:19:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561193002/1
4 years, 11 months ago (2016-01-06 17:20:00 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9483)
4 years, 11 months ago (2016-01-06 17:30:56 UTC) #6
adamk
lgtm
4 years, 11 months ago (2016-01-06 18:49:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561193002/1
4 years, 11 months ago (2016-01-06 18:49:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-06 18:50:49 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 18:51:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6cd8535c3b369cf07b4c0eae8075820f1c229df5
Cr-Commit-Position: refs/heads/master@{#33137}

Powered by Google App Engine
This is Rietveld 408576698