Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 156113005: ARM Skia NEON patches - 27 - S32A_D565_Blend (Closed)

Created:
6 years, 10 months ago by kevin.petit
Modified:
6 years, 10 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

ARM Skia NEON patches - 27 - S32A_D565_Blend BlitRow565: new intrinsics version of S32A_D565_Blend This new version is basically a rewrite of the existing code with a few speed and accuracy improvements. There is a switch to enable pixel perfect results at the cost of a (quite big) decrease of performances (disabled in this patch). Here are the benchmark results (speedup vs. existing code): +-------+------------+------------+ | count | Cortex -A9 | Cortex-A15 | +-------+------------+------------+ | 1 | +103.6% | +12% | +-------+------------+------------+ | 2 | +3.6% | +21.6% | +-------+------------+------------+ | 4 | +0.8% | -0.8% | +-------+------------+------------+ | 8 | +3.9% | -1% | +-------+------------+------------+ | 16 | +14.7% | +5.7% | +-------+------------+------------+ | 64 | +18.1% | +13.2% | +-------+------------+------------+ | 256 | +16.3% | +27.4% | +-------+------------+------------+ | 1024 | +78.2% | +17.4% | +-------+------------+------------+ Signed-off-by: Kévin PETIT <kevin.petit@arm.com>; BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13438

Patch Set 1 #

Patch Set 2 : Add ignored-tests.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -94 lines) Patch
M expectations/gm/ignored-tests.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm_neon.cpp View 1 chunk +104 lines, -94 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kevin.petit
This one will allow to share more code with aarch64 whilst enjoying a nice speedup ...
6 years, 10 months ago (2014-02-10 16:26:23 UTC) #1
djsollen
lgtm
6 years, 10 months ago (2014-02-13 17:37:27 UTC) #2
djsollen
don't forgot to rebaseline and remove the ignored tests after submitting this.
6 years, 10 months ago (2014-02-13 17:38:50 UTC) #3
kevin.petit
The CQ bit was checked by kevin.petit@arm.com
6 years, 10 months ago (2014-02-13 17:41:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kevin.petit@arm.com/156113005/10001
6 years, 10 months ago (2014-02-13 17:41:31 UTC) #5
kevin.petit
On 2014/02/13 17:38:50, djsollen wrote: > don't forgot to rebaseline and remove the ignored tests ...
6 years, 10 months ago (2014-02-13 17:41:56 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 18:37:44 UTC) #7
Message was sent while issue was closed.
Change committed as 13438

Powered by Google App Engine
This is Rietveld 408576698