Set LibraryElement.entryPoint properly during summary resynthesis.

Set LibraryElement.entryPoint properly during summary resynthesis.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/55a3de53dc1915c053a9ba11bde1cf3a2718fb77

[Paul Berry, 2016-01-08 00:07:30]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-01-08 00:52:08]

LGTM

[scheglov, 2016-01-08 06:17:44]

scheglov@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2016-01-08 06:17:44]

https://codereview.chromium.org/1561073007/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1561073007/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:678: FunctionElement
unitEntryPoint = populateUnit(parts[i], i + 1);
We need to check also exported libraries.

18.4 Scripts scripts:  A script is a library whose exported namespace (18.2)
includes a top-level
member named main.

https://codereview.chromium.org/1561073007/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:974: if (function.name == 'main')
{
Or could also use `function.isEntryPoint` instead.

[Paul Berry, 2016-01-08 18:25:57]

https://codereview.chromium.org/1561073007/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1561073007/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:678: FunctionElement
unitEntryPoint = populateUnit(parts[i], i + 1);
On 2016/01/08 06:17:44, scheglov wrote:
> We need to check also exported libraries.
> 
> 18.4 Scripts scripts:  A script is a library whose exported namespace (18.2)
> includes a top-level
> member named main.

Oops, good catch!  I've added failing tests and a TODO comment, and I'll address
this in a follow-up CL.

https://codereview.chromium.org/1561073007/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:974: if (function.name == 'main')
{
On 2016/01/08 06:17:44, scheglov wrote:
> Or could also use `function.isEntryPoint` instead.

Done.

[Paul Berry, 2016-01-08 18:32:05]

Description was changed from

==========
Set LibraryElement.entryPoint properly during summary resynthesis.
==========

to

==========
Set LibraryElement.entryPoint properly during summary resynthesis.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/55a3de53dc1915c053a9ba11bde1cf3a2718fb77
==========

[Paul Berry, 2016-01-08 18:32:06]

Committed patchset #1 (id:1) manually as
55a3de53dc1915c053a9ba11bde1cf3a2718fb77 (presubmit successful).