Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1560963002: Do TypePropagation again after inlining (Closed)

Created:
4 years, 11 months ago by sra1
Modified:
4 years, 11 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : #

Patch Set 2 : baseline #

Patch Set 3 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -77 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 3 chunks +8 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/closures_10.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/closures_15.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + tests/compiler/dart2js/cps_ir/expected/closures_16.js View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/codeUnitAt_2.js View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/control_flow_2.js View 1 2 2 chunks +9 lines, -15 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/control_flow_3.js View 1 2 2 chunks +7 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/control_flow_4.js View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/control_flow_5.js View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/operators2_1.js View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/operators2_2.js View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/operators2_7.js View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/operators_5.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/supercall_1.js View 1 2 2 chunks +3 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/supercall_2.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
A tests/compiler/dart2js/cps_ir/input/closures_16.dart View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/input/control_flow_2.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/cps_ir/input/control_flow_3.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/cps_ir/input/control_flow_4.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/cps_ir/input/control_flow_5.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/cps_ir/input/operators2_1.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/input/operators2_2.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/input/operators2_7.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/input/supercall_1.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/cps_ir/update_all.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
sra1
4 years, 11 months ago (2016-01-13 23:18:13 UTC) #4
asgerf
lgtm
4 years, 11 months ago (2016-01-13 23:19:22 UTC) #5
sra1
Committed patchset #1 (id:40001) manually as 9392a2ece91d550188bab7aa82b4b43e5615c0c5 (presubmit successful).
4 years, 11 months ago (2016-01-13 23:32:24 UTC) #7
sra1
4 years, 11 months ago (2016-01-14 04:03:58 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:80001) manually as
a56036b0a3c3acdbd4565508696b5b86d53eecb2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698