Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: content/browser/gpu/gpu_data_manager_impl_private.cc

Issue 1560953002: Implement fallback from WMPI to WMPA. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment to gpu_data_manager_impl_private.cc Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/gpu/gpu_data_manager_impl_private.cc
diff --git a/content/browser/gpu/gpu_data_manager_impl_private.cc b/content/browser/gpu/gpu_data_manager_impl_private.cc
index 926886d3e8baa457f780b054064c5bb8e481d2a6..577581ba8c42e08d40ff030991922609e1360bb7 100644
--- a/content/browser/gpu/gpu_data_manager_impl_private.cc
+++ b/content/browser/gpu/gpu_data_manager_impl_private.cc
@@ -933,6 +933,19 @@ bool GpuDataManagerImplPrivate::ShouldDisableAcceleratedVideoDecode(
return true;
if (group_name == "Disabled")
return true;
+
+ // Accelerated decode is not available at all with --disable-gpu. It may be
+ // possible to eventually support --single-process and/or --in-process-gpu,
+ // but currently it fails long before trying because the supported profiles
+ // list isn't initialized. Setting the disable flag in these case is important
+ // for Android, as there is no fallback path if the renderer process chooses
+ // wrong.
+ if (command_line->HasSwitch(switches::kDisableGpu) ||
DaleCurtis 2016/01/06 21:03:22 This is going to mean no webview support since the
sandersd (OOO until July 31) 2016/01/06 22:20:38 I agree, but I don't think this is going to get fi
+ command_line->HasSwitch(switches::kSingleProcess) ||
+ command_line->HasSwitch(switches::kInProcessGPU)) {
+ return true;
+ }
+
return false;
}
« no previous file with comments | « no previous file | content/renderer/media/android/webmediaplayer_android.h » ('j') | content/renderer/render_frame_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698