Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: pydir/crosstest.py

Issue 1560933002: Subzero: Enable Non-SFI vector cross tests. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« crosstest/test_arith_main.cpp ('K') | « crosstest/test_select_main.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pydir/crosstest.py
diff --git a/pydir/crosstest.py b/pydir/crosstest.py
index 50946cad518ae0dca6481326bd886ab8373f6fda..dc2da2b6ed5695572a951e70bdcadcf9ad963108 100755
--- a/pydir/crosstest.py
+++ b/pydir/crosstest.py
@@ -126,7 +126,6 @@ def main():
bitcode = os.path.join(args.dir, base + '.' + key + '.pnacl.ll')
shellcmd(['{bin}/pnacl-clang'.format(bin=bindir),
('-O2' if args.clang_opt else '-O0'),
- get_sfi_string(args, '', '-DNONSFI', ''),
('-DARM32' if args.target == 'arm32' else ''), '-c', arg,
'-o', bitcode_nonfinal])
shellcmd(['{bin}/pnacl-opt'.format(bin=bindir),
@@ -211,8 +210,6 @@ def main():
if args.target == 'arm32':
target_params.append('-DARM32')
target_params.append('-static')
- if args.nonsfi:
- target_params.append('-DNONSFI')
pure_c = os.path.splitext(args.driver)[1] == '.c'
if not args.nonsfi:
@@ -242,7 +239,6 @@ def main():
cc='clang' if pure_c else 'clang++')
shellcmd([compiler,
args.driver,
- '-DNONSFI' if args.nonsfi else '',
'-O2',
'-o', bitcode_nonfinal,
'-Wl,-r'
« crosstest/test_arith_main.cpp ('K') | « crosstest/test_select_main.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698