Subzero: Enable Non-SFI vector cross tests.

Subzero: Enable Non-SFI vector cross tests.

The driver programs for vector tests use a loop to initialize vector-type values one element at a time.  The PNaCl ABI requires the vector element index to be a constant, and the createConstantInsertExtractElementIndexPass() transformation creates an alloca instruction.  When this alloca is inside a loop, it can (and does in the cross tests) cause a stack overflow.

The workaround here is to use a noinline helper function to do the insertelement.

We didn't run into this problem until now because native and sandbox cross tests build the driver in a different way that presumably avoids running the PNaCl ABI simplification passes.

BUG= none
R=jpp@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=57a8aab25be274677117e42260e316765c0e15cd

[Jim Stichnoth, 2016-01-06 00:14:00]

Description was changed from

==========
Subzero: Enable Non-SFI vector cross tests.

BUG= none
==========

to

==========
Subzero: Enable Non-SFI vector cross tests.

The driver programs for vector tests use a loop to initialize vector-type values
one element at a time.  The PNaCl ABI requires the vector element index to be a
constant, and the createConstantInsertExtractElementIndexPass() transformation
creates an alloca instruction.  When this alloca is inside a loop, it can (and
does in the cross tests) cause a stack overflow.

The workaround here is to use a noinline helper function to do the
insertelement.

We didn't run into this problem until now because native and sandbox cross test
builds 

BUG= none
==========

[Jim Stichnoth, 2016-01-06 00:23:05]

Description was changed from

==========
Subzero: Enable Non-SFI vector cross tests.

The driver programs for vector tests use a loop to initialize vector-type values
one element at a time.  The PNaCl ABI requires the vector element index to be a
constant, and the createConstantInsertExtractElementIndexPass() transformation
creates an alloca instruction.  When this alloca is inside a loop, it can (and
does in the cross tests) cause a stack overflow.

The workaround here is to use a noinline helper function to do the
insertelement.

We didn't run into this problem until now because native and sandbox cross test
builds 

BUG= none
==========

to

==========
Subzero: Enable Non-SFI vector cross tests.

The driver programs for vector tests use a loop to initialize vector-type values
one element at a time.  The PNaCl ABI requires the vector element index to be a
constant, and the createConstantInsertExtractElementIndexPass() transformation
creates an alloca instruction.  When this alloca is inside a loop, it can (and
does in the cross tests) cause a stack overflow.

The workaround here is to use a noinline helper function to do the
insertelement.

We didn't run into this problem until now because native and sandbox cross tests
build the driver in a different way that presumably avoids running the PNaCl ABI
simplification passes.

BUG= none
==========

[Jim Stichnoth, 2016-01-06 00:23:05]

stichnot@chromium.org changed reviewers:
+ jpp@chromium.org, kschimpf@google.com, sehr@chromium.org

[John, 2016-01-06 15:24:26]

lgtm

https://codereview.chromium.org/1560933002/diff/1/crosstest/test_arith_main.cpp
File crosstest/test_arith_main.cpp (right):

https://codereview.chromium.org/1560933002/diff/1/crosstest/test_arith_main.c...
crosstest/test_arith_main.cpp:217: setElement<TypeUnsigned,
ElementTypeUnsigned>(Value1, j, Element1);
Do you need the template parameters? I would guess the compiler would infer
TypeUnsigned, and ElementTypeUnsigned, from Value1 and Element1

[Jim Stichnoth, 2016-01-06 17:34:30]

https://codereview.chromium.org/1560933002/diff/1/crosstest/test_arith_main.cpp
File crosstest/test_arith_main.cpp (right):

https://codereview.chromium.org/1560933002/diff/1/crosstest/test_arith_main.c...
crosstest/test_arith_main.cpp:217: setElement<TypeUnsigned,
ElementTypeUnsigned>(Value1, j, Element1);
On 2016/01/06 15:24:26, John wrote:
> Do you need the template parameters? I would guess the compiler would infer
> TypeUnsigned, and ElementTypeUnsigned, from Value1 and Element1

Done.

[Jim Stichnoth, 2016-01-06 17:34:40]

Description was changed from

==========
Subzero: Enable Non-SFI vector cross tests.

The driver programs for vector tests use a loop to initialize vector-type values
one element at a time.  The PNaCl ABI requires the vector element index to be a
constant, and the createConstantInsertExtractElementIndexPass() transformation
creates an alloca instruction.  When this alloca is inside a loop, it can (and
does in the cross tests) cause a stack overflow.

The workaround here is to use a noinline helper function to do the
insertelement.

We didn't run into this problem until now because native and sandbox cross tests
build the driver in a different way that presumably avoids running the PNaCl ABI
simplification passes.

BUG= none
==========

to

==========
Subzero: Enable Non-SFI vector cross tests.

The driver programs for vector tests use a loop to initialize vector-type values
one element at a time.  The PNaCl ABI requires the vector element index to be a
constant, and the createConstantInsertExtractElementIndexPass() transformation
creates an alloca instruction.  When this alloca is inside a loop, it can (and
does in the cross tests) cause a stack overflow.

The workaround here is to use a noinline helper function to do the
insertelement.

We didn't run into this problem until now because native and sandbox cross tests
build the driver in a different way that presumably avoids running the PNaCl ABI
simplification passes.

BUG= none
R=jpp@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-01-06 17:34:41]

Committed patchset #2 (id:20001) manually as
57a8aab25be274677117e42260e316765c0e15cd (presubmit successful).