runtime/vm/service_isolate.cc - Issue 1560853002: Fix Shutdown race.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/service_isolate.cc

Issue 1560853002: Fix Shutdown race. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/service_isolate.cc

diff --git a/runtime/vm/service_isolate.cc b/runtime/vm/service_isolate.cc

index 923f6d4c43e65bca1d8e6fe09d7988606e95a499..a316c6ccc6c596db9fb503ada73f564447037ead 100644

--- a/runtime/vm/service_isolate.cc

+++ b/runtime/vm/service_isolate.cc

@@ -344,6 +344,7 @@ class RunServiceTask : public ThreadPool::Task {

ASSERT(ServiceIsolate::IsServiceIsolate(I));

ServiceIsolate::SetServiceIsolate(NULL);

ServiceIsolate::SetServicePort(ILLEGAL_PORT);

+ I->WaitForOutstandingSpawns();

{

// Print the error if there is one. This may execute dart code to

// print the exception object, so we need to use a StartIsolateScope.

« no previous file with comments | « runtime/vm/isolate.cc ('k') | no next file » | no next file with comments »