Add Array support for @@species and subclassing

src/objects.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/objects.h"
 
 #include <cmath>
 #include <iomanip>
 #include <sstream>
 
@@ skipping 1587 matching lines @@
       Simd128Value* a = Simd128Value::cast(this);
       Simd128Value* b = Simd128Value::cast(other);
       return a->map()->instance_type() == b->map()->instance_type() &&
              a->BitwiseEquals(b);
     }
   }
   return false;
 }
 
 
+MaybeHandle<Object> Object::ArraySpeciesConstructor(
+    Isolate* isolate, Handle<Object> original_array) {
+  Handle<Context> native_context = isolate->native_context();
+  if (!FLAG_harmony_species) {
+    return Handle<Object>(native_context->array_function(), isolate);
+  }
+  Handle<Object> constructor = isolate->factory()->undefined_value();
+  Maybe<bool> is_array = Object::IsArray(original_array);
+  MAYBE_RETURN_NULL(is_array);
+  if (is_array.FromJust()) {
+    ASSIGN_RETURN_ON_EXCEPTION(
+        isolate, constructor,
+        Object::GetProperty(original_array,
+                            isolate->factory()->constructor_string()),
+        Object);
+    if (constructor->IsConstructor()) {
+      Handle<Context> constructor_context;
+      ASSIGN_RETURN_ON_EXCEPTION(
+          isolate, constructor_context,
+          JSReceiver::GetFunctionRealm(Handle<JSReceiver>::cast(constructor)),

[adamk, 2016/01/07 01:11:04]

Did this need changing to make proxies work? Can you add a test where a Proxy is
shows up here?

[Dan Ehrenberg, 2016/01/07 01:35:17]

Yeah, you caught me. I couldn't think of a great test that really exercised
their Proxy-ness, but I added a test that makes sure that things don't crash in
this case.

[adamk, 2016/01/07 01:38:30]

Not crashing is sufficient to allay my fears.

+          Object);
+      if (*constructor_context != *native_context &&
+          *constructor == constructor_context->array_function()) {
+        constructor = isolate->factory()->undefined_value();
+      }
+    }
+    if (constructor->IsJSReceiver()) {
+      ASSIGN_RETURN_ON_EXCEPTION(
+          isolate, constructor,
+          Object::GetProperty(constructor,
+                              isolate->factory()->species_symbol()),
+          Object);
+      if (constructor->IsNull()) {
+        constructor = isolate->factory()->undefined_value();
+      }
+    }
+  }
+  if (constructor->IsUndefined()) {
+    return Handle<Object>(native_context->array_function(), isolate);
+  } else {
+    if (!constructor->IsConstructor()) {
+      return isolate->Throw<Object>(isolate->factory()->NewTypeError(

[adamk, 2016/01/07 01:11:04]

Looks like there's a macro for this:

THROW_NEW_ERROR(isolate,
                NewTypeError(MessageTemplate::kSpeciesNotConstructor),
                Object);

I'm not totally sure that's worth a macro, but it's what all the other code in
objects.cc does, so I'd prefer consistency here.

[Dan Ehrenberg, 2016/01/07 01:35:17]

OK, sure.

[adamk, 2016/01/07 01:38:30]

Sorry, it's the week of macros!

+          MessageTemplate::kSpeciesNotConstructor));
+    }
+    return constructor;
+  }
+}
+
+
 void Object::ShortPrint(FILE* out) {
   OFStream os(out);
   os << Brief(this);
 }
 
 
 void Object::ShortPrint(StringStream* accumulator) {
   std::ostringstream os;
   os << Brief(this);
   accumulator->Add(os.str().c_str());
@@ skipping 17936 matching lines @@
   if (cell->value() != *new_value) {
     cell->set_value(*new_value);
     Isolate* isolate = cell->GetIsolate();
     cell->dependent_code()->DeoptimizeDependentCodeGroup(
         isolate, DependentCode::kPropertyCellChangedGroup);
   }
 }
 
 }  // namespace internal
 }  // namespace v8