Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 1560723002: Revert of Moved parent_->SchedulePaint() to Views::SetFillsBoundsOpaquely() and Views::ScheduleP (Closed)

Created:
4 years, 11 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 11 months ago
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Moved parent_->SchedulePaint() to Views::SetFillsBoundsOpaquely() and Views::SchedulePaint(). (patchset #8 id:140001 of https://codereview.chromium.org/1461673002/ ) Reason for revert: These tests leak https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/8315 Original issue's description: > This CL fixes a more general issue in Views that had a quick fix > that landed here: https://codereview.chromium.org/1460733002/ > > The general problem is that the layer owned by a parent View can > become dirty/stale when a child view is painting to it's own layer. > This CL fixes the problem by scheduling paints on the parent view > when it may be dirty. > > BUG=551492, 546683 > TEST=ViewLayerTest.NoCrashWhenParentlessViewSchedulesPaintOnParent > ViewLayerTest.ScheduledRectsInParentAfterSchedulingPaint > ViewLayerTest.ParentPaintWhenSwitchingPaintToLayerFromFalseToTrue > ViewLayerTest.NoParentPaintWhenSwitchingPaintToLayerFromTrueToTrue > > Committed: https://crrev.com/c8761106916aac604f30fb2223cdbfb2bd3ffda3 > Cr-Commit-Position: refs/heads/master@{#367536} TBR=sadrul@chromium.org,jonross@chromium.org,sky@chromium.org,bruthig@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=551492, 546683 Committed: https://crrev.com/70e4baf6b13f7e4fda458ea4c9f684c55bed957c Cr-Commit-Position: refs/heads/master@{#367563}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -65 lines) Patch
M chrome/browser/ui/views/toolbar/toolbar_button.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/view.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/views/view.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M ui/views/view_unittest.cc View 2 chunks +0 lines, -47 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
Ken Rockot(use gerrit already)
Created Revert of Moved parent_->SchedulePaint() to Views::SetFillsBoundsOpaquely() and Views::SchedulePaint().
4 years, 11 months ago (2016-01-05 17:41:43 UTC) #1
Dan Beam
https://codereview.chromium.org/1560723002/diff/1/ui/views/view_unittest.cc File ui/views/view_unittest.cc (left): https://codereview.chromium.org/1560723002/diff/1/ui/views/view_unittest.cc#oldcode3992 ui/views/view_unittest.cc:3992: TestView* v = new TestView; TestView v; SchedulePaintOnParent(&v); would ...
4 years, 11 months ago (2016-01-05 18:06:08 UTC) #4
bruthig
4 years, 11 months ago (2016-01-06 16:37:05 UTC) #5
Message was sent while issue was closed.
Re-landed original patch set here: https://codereview.chromium.org/1566693002/

Powered by Google App Engine
This is Rietveld 408576698