Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1560663004: Parse generic function declarations with/without type. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Parse generic function declarations with/without type. Currently we parse only 'void' generic function declarations. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3d3b875661064e2ac25d744157b1803361dc316d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -9 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 3 chunks +13 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 2 chunks +24 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 11 months ago (2016-01-05 21:41:31 UTC) #1
Brian Wilkerson
LGTM
4 years, 11 months ago (2016-01-05 22:31:11 UTC) #2
scheglov
4 years, 11 months ago (2016-01-05 22:52:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3d3b875661064e2ac25d744157b1803361dc316d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698