Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1426)

Issue 1560663003: Fix VS 2015 64-bit truncation warning (Closed)

Created:
4 years, 11 months ago by brucedawson
Modified:
4 years, 11 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, Kimmo Kinnunen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix VS 2015 64-bit truncation warning crrev.com/1509833002 introduced a VS 2015 64-bit truncation warning. This fixes it with a cast. The warning is: egl.cc(129): warning C4267: conversion from 'size_t' to 'int', possible loss of data R=piman@chromium.org BUG=440500 Committed: https://crrev.com/1fc1fd5b26c69e91b6ffd0fa15e30f12e21d4221 Cr-Commit-Position: refs/heads/master@{#367678}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gpu/gles2_conform_support/egl/egl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
brucedawson
PTAL
4 years, 11 months ago (2016-01-05 20:58:41 UTC) #2
piman
lgtm
4 years, 11 months ago (2016-01-05 22:41:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1560663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1560663003/1
4 years, 11 months ago (2016-01-05 22:44:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 23:05:56 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 23:07:23 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1fc1fd5b26c69e91b6ffd0fa15e30f12e21d4221
Cr-Commit-Position: refs/heads/master@{#367678}

Powered by Google App Engine
This is Rietveld 408576698