Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1560583002: DevTools: remove experimental webrtc-based remote debugging device provider. (Closed)

Created:
4 years, 11 months ago by pfeldman
Modified:
4 years, 11 months ago
CC:
chromium-reviews, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove experimental webrtc-based remote debugging device provider. R=mnaganov TBR=jochen BUG=574279 Committed: https://crrev.com/0ffe42afb225ef1f7526df8a0d4502efdddab508 Cr-Commit-Position: refs/heads/master@{#367595}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : more tests/gyp removals #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1395 lines) Patch
M chrome/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/devtools/BUILD.gn View 3 chunks +0 lines, -23 lines 0 comments Download
M chrome/browser/devtools/device/devtools_android_bridge.h View 3 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/devtools/device/devtools_android_bridge.cc View 6 chunks +2 lines, -32 lines 0 comments Download
D chrome/browser/devtools/device/webrtc/background_worker.html View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/browser/devtools/device/webrtc/devtools_bridge_client.h View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/browser/devtools/device/webrtc/devtools_bridge_client.cc View 1 chunk +0 lines, -267 lines 0 comments Download
D chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.h View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.cc View 1 chunk +0 lines, -185 lines 0 comments Download
D chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.js View 1 chunk +0 lines, -116 lines 0 comments Download
D chrome/browser/devtools/device/webrtc/devtools_bridge_instances_request.h View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/devtools/device/webrtc/devtools_bridge_instances_request.cc View 1 chunk +0 lines, -86 lines 0 comments Download
D chrome/browser/devtools/device/webrtc/devtools_bridge_instances_request_unittest.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/devtools/device/webrtc/js/webrtc_device_provider.js View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/devtools/device/webrtc/resources.grd View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/devtools/device/webrtc/send_command_request.h View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/devtools/device/webrtc/send_command_request.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/devtools/device/webrtc/webrtc_device_provider.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/devtools/device/webrtc/webrtc_device_provider.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D chrome/browser/devtools/device/webrtc/webrtc_device_provider_browsertest.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/devtools/webrtc_device_provider_resources.gyp View 1 chunk +0 lines, -26 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/chrome_debugger.gypi View 1 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/chrome_repack_resources.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_resources.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/url_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/url_constants.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M tools/gritsettings/resource_ids View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 27 (13 generated)
pfeldman
4 years, 11 months ago (2016-01-05 01:05:40 UTC) #2
mnaganov (inactive)
lgtm
4 years, 11 months ago (2016-01-05 01:09:58 UTC) #3
Vitaly Buka (NO REVIEWS)
lgtm
4 years, 11 months ago (2016-01-05 01:17:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1560583002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1560583002/40001
4 years, 11 months ago (2016-01-05 01:19:07 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/132425)
4 years, 11 months ago (2016-01-05 01:31:02 UTC) #10
pfeldman
4 years, 11 months ago (2016-01-05 01:40:39 UTC) #12
pfeldman
+Nico, jochen for OWNERS review.
4 years, 11 months ago (2016-01-05 01:41:25 UTC) #13
Lei Zhang
Since I apparently have a CL that depends on this, chrome/ lgtm.
4 years, 11 months ago (2016-01-05 02:37:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1560583002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1560583002/40001
4 years, 11 months ago (2016-01-05 02:39:22 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/132446)
4 years, 11 months ago (2016-01-05 02:49:26 UTC) #19
pfeldman
On 2016/01/05 02:49:26, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 11 months ago (2016-01-05 18:40:54 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1560583002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1560583002/40001
4 years, 11 months ago (2016-01-05 18:42:01 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-05 18:50:42 UTC) #25
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 18:51:48 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0ffe42afb225ef1f7526df8a0d4502efdddab508
Cr-Commit-Position: refs/heads/master@{#367595}

Powered by Google App Engine
This is Rietveld 408576698