chrome/android/java/res/layout/infobar_wrapper.xml - Issue 1560573002: Reduce infobar lag on KitKat from 1000ms to 100ms.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/infobar_wrapper.xml

Issue 1560573002: Reduce infobar lag on KitKat from 1000ms to 100ms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: appease the FindBugs gods Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <!-- Use RelativeLayout because it has a gravity attribute, unlike FrameLayout.	6 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"

7 During infobar swap animations, two child views are added to this infobar

8 wrapper, and gravity="top" ensures they're both aligned at the top. -->

9 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"

10 android:layout_width="match_parent"	7 android:layout_width="match_parent"

11 android:layout_height="wrap_content"	8 android:layout_height="wrap_content"

12 android:background="@drawable/infobar_bg"	9 android:background="@drawable/infobar_bg"

13 android:gravity="top"

14 android:minHeight="@dimen/infobar_peeking_height_with_shadow"	10 android:minHeight="@dimen/infobar_peeking_height_with_shadow"

15 android:paddingTop="@dimen/infobar_shadow_height" />	11 android:paddingTop="@dimen/infobar_shadow_height" />

OLD	NEW