Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1560533004: Android: Explicitly tear down LayerTreeHost first, take 2 (Closed)

Created:
4 years, 11 months ago by no sievers
Modified:
4 years, 11 months ago
Reviewers:
brianderson
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Explicitly tear down LayerTreeHost first, take 2 In particiular, there might be CompositorImpl::VSyncObservers that are indirectly owned by LTH, so make sure those go away before the ObserverList. TBR=brianderson@chromium.org BUG=571030, 571148 Committed: https://crrev.com/1a9f503ebfef2f89531eccb435e0b27f4bd101f1 Cr-Commit-Position: refs/heads/master@{#367703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M content/browser/renderer_host/compositor_impl_android.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1560533004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1560533004/1
4 years, 11 months ago (2016-01-05 22:56:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 23:56:04 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 23:56:46 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a9f503ebfef2f89531eccb435e0b27f4bd101f1
Cr-Commit-Position: refs/heads/master@{#367703}

Powered by Google App Engine
This is Rietveld 408576698