Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: ui/gl/gl_surface_egl.cc

Issue 1560523002: Use EGL_ANGLE_surface_orientation in Chrome to avoid a blit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gl/gl_surface_egl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_surface_egl.cc
diff --git a/ui/gl/gl_surface_egl.cc b/ui/gl/gl_surface_egl.cc
index 9107bdd90ecb78b190fed84087f99d6a343974f8..0bc4cca1853a63058d527c999f4d41242f0859c5 100644
--- a/ui/gl/gl_surface_egl.cc
+++ b/ui/gl/gl_surface_egl.cc
@@ -80,6 +80,14 @@ extern "C" {
#define EGL_X11_VISUAL_ID_ANGLE 0x33A3
#endif /* EGL_ANGLE_x11_visual */
+#ifndef EGL_ANGLE_surface_orientation
+#define EGL_ANGLE_surface_orientation
+#define EGL_OPTIMAL_SURFACE_ORIENTATION_ANGLE 0x33A7
+#define EGL_SURFACE_ORIENTATION_ANGLE 0x33A8
+#define EGL_SURFACE_ORIENTATION_INVERT_X_ANGLE 0x0001
+#define EGL_SURFACE_ORIENTATION_INVERT_Y_ANGLE 0x0002
+#endif /* EGL_ANGLE_surface_orientation */
+
using ui::GetLastEGLErrorString;
namespace gfx {
@@ -103,6 +111,7 @@ bool g_egl_create_context_robustness_supported = false;
bool g_egl_sync_control_supported = false;
bool g_egl_window_fixed_size_supported = false;
bool g_egl_surfaceless_context_supported = false;
+bool g_egl_surface_orientation_supported = false;
class EGLSyncControlVSyncProvider
: public gfx::SyncControlVSyncProvider {
@@ -360,6 +369,8 @@ bool GLSurfaceEGL::InitializeOneOff() {
HasEGLExtension("EGL_CHROMIUM_sync_control");
g_egl_window_fixed_size_supported =
HasEGLExtension("EGL_ANGLE_window_fixed_size");
+ g_egl_surface_orientation_supported =
+ HasEGLExtension("EGL_ANGLE_surface_orientation");
// TODO(oetuaho@nvidia.com): Surfaceless is disabled on Android as a temporary
// workaround, since code written for Android WebView takes different paths
@@ -488,6 +499,7 @@ NativeViewGLSurfaceEGL::NativeViewGLSurfaceEGL(EGLNativeWindowType window)
surface_(NULL),
supports_post_sub_buffer_(false),
alpha_(true),
+ flips_vertically_(false),
swap_interval_(1) {
#if defined(OS_ANDROID)
if (window)
@@ -539,6 +551,18 @@ bool NativeViewGLSurfaceEGL::Initialize(
egl_window_attributes.push_back(EGL_TRUE);
}
+ if (g_egl_surface_orientation_supported) {
+ EGLint attrib;
+ eglGetConfigAttrib(GetDisplay(), GetConfig(),
+ EGL_OPTIMAL_SURFACE_ORIENTATION_ANGLE, &attrib);
+ flips_vertically_ = (attrib == EGL_SURFACE_ORIENTATION_INVERT_Y_ANGLE);
+ }
+
+ if (flips_vertically_) {
+ egl_window_attributes.push_back(EGL_SURFACE_ORIENTATION_ANGLE);
+ egl_window_attributes.push_back(EGL_SURFACE_ORIENTATION_INVERT_Y_ANGLE);
+ }
+
egl_window_attributes.push_back(EGL_NONE);
// Create a surface for the native window.
surface_ = eglCreateWindowSurface(
@@ -700,6 +724,10 @@ bool NativeViewGLSurfaceEGL::SupportsPostSubBuffer() {
return supports_post_sub_buffer_;
}
+bool NativeViewGLSurfaceEGL::FlipsVertically() const {
+ return flips_vertically_;
+}
+
gfx::SwapResult NativeViewGLSurfaceEGL::PostSubBuffer(int x,
int y,
int width,
@@ -709,6 +737,12 @@ gfx::SwapResult NativeViewGLSurfaceEGL::PostSubBuffer(int x,
DVLOG(1) << "Failed to commit pending overlay planes.";
return gfx::SwapResult::SWAP_FAILED;
}
+ if (flips_vertically_) {
+ // With EGL_SURFACE_ORIENTATION_INVERT_Y_ANGLE the contents are rendered
+ // inverted, but the PostSubBuffer rectangle is still measured from the
+ // bottom left.
+ y = GetSize().height() - y - height;
+ }
if (!eglPostSubBufferNV(GetDisplay(), surface_, x, y, width, height)) {
DVLOG(1) << "eglPostSubBufferNV failed with error "
<< GetLastEGLErrorString();
« no previous file with comments | « ui/gl/gl_surface_egl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698