Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1560523002: Use EGL_ANGLE_surface_orientation in Chrome to avoid a blit. (Closed)

Created:
4 years, 11 months ago by jbauman
Modified:
4 years, 11 months ago
Reviewers:
dcheng, piman
CC:
chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org, sievers+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use EGL_ANGLE_surface_orientation in Chrome to avoid a blit. With EGL_ANGLE_surface_orientation, Chrome can set EGL_SURFACE_ORIENTATION_INVERT_Y_ANGLE on the backbuffer and flip the drawing of the backbuffer itself. This avoids a blit inside ANGLE, which reduces power consumption from 6.4W to 6.0W on a fullscreen h.264 video in my testing. A new gpu capability is added to inform the compositor that a flip is needed. BUG=525379 Committed: https://crrev.com/21e38674f87492aa0ecb54a97df709ecd8b05feb Cr-Commit-Position: refs/heads/master@{#367700}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -0 lines) Patch
M content/browser/compositor/gpu_browser_compositor_output_surface.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/capabilities.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/capabilities.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/ipc/gpu_command_buffer_traits_multi.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_surface.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M ui/gl/gl_surface.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_egl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 7 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jbauman
piman@: please review dcheng@: minor gpu\ipc\gpu_command_buffer_traits_multi.h change
4 years, 11 months ago (2016-01-05 01:05:45 UTC) #2
piman
LGTM, though please double-check that things like casting and screenshots still work correctly. I'm not ...
4 years, 11 months ago (2016-01-05 01:20:05 UTC) #3
dcheng
lgtm for ipc changes
4 years, 11 months ago (2016-01-05 01:36:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1560523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1560523002/20001
4 years, 11 months ago (2016-01-05 23:42:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-05 23:49:54 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 23:50:43 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/21e38674f87492aa0ecb54a97df709ecd8b05feb
Cr-Commit-Position: refs/heads/master@{#367700}

Powered by Google App Engine
This is Rietveld 408576698