Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1560443002: Revert of Flipping FEC flag at client to enable FEC protection on connection from client to server. (Closed)

Created:
4 years, 11 months ago by Ryan Hamilton
Modified:
4 years, 11 months ago
Reviewers:
Jana
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@home
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Flipping FEC flag at client to enable FEC protection on connection from client to server. (patchset #1 id:1 of https://codereview.chromium.org/1523423002/ ) Reason for revert: Might expose bug in FEC timeouts. Original issue's description: > Flipping FEC flag at client to enable FEC protection on connection from client to server. > > R=rch@chromium.org > BUG= > > Committed: https://crrev.com/abc35c951aef78e67913b44932cd55e976cc39a9 > Cr-Commit-Position: refs/heads/master@{#365574} TBR=jri@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/73d4b65b388a2469d5d368d8e8c40f45f9c977db Cr-Commit-Position: refs/heads/master@{#367334}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/quic/quic_flags.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Ryan Hamilton
Created Revert of Flipping FEC flag at client to enable FEC protection on connection from ...
4 years, 11 months ago (2016-01-04 18:54:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1560443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1560443002/1
4 years, 11 months ago (2016-01-04 18:56:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-04 18:58:23 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 18:59:27 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73d4b65b388a2469d5d368d8e8c40f45f9c977db
Cr-Commit-Position: refs/heads/master@{#367334}

Powered by Google App Engine
This is Rietveld 408576698