Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 1560403002: Scale scrollbar in use-zoom-for-dsf mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
index b021e1f6e147bd140ab344ab63024deced98e302..96e6da16a91ac4a8959db6209442f12a5eb20fbb 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
@@ -240,16 +240,16 @@ static IntRect cornerRect(const LayoutBox& box, const Scrollbar* horizontalScrol
// FIXME: This isn't right. We need to know the thickness of custom scrollbars
// even when they don't exist in order to set the resizer square size properly.
horizontalThickness = ScrollbarTheme::theme().scrollbarThickness();
- verticalThickness = horizontalThickness;
+ verticalThickness = verticalScrollbar->scrollbarThickness();
} else if (verticalScrollbar && !horizontalScrollbar) {
- horizontalThickness = verticalScrollbar->width();
+ horizontalThickness = verticalScrollbar->scrollbarThickness();
verticalThickness = horizontalThickness;
} else if (horizontalScrollbar && !verticalScrollbar) {
- verticalThickness = horizontalScrollbar->height();
+ verticalThickness = horizontalScrollbar->scrollbarThickness();
horizontalThickness = verticalThickness;
} else {
- horizontalThickness = verticalScrollbar->width();
- verticalThickness = horizontalScrollbar->height();
+ horizontalThickness = horizontalScrollbar->scrollbarThickness();
skobes 2016/01/13 23:46:00 This line and the next are backwards?
oshima 2016/01/13 23:56:45 Good catch, thanks!
+ verticalThickness = verticalScrollbar->scrollbarThickness();
}
return IntRect(cornerStart(box, bounds.x(), bounds.maxX(), horizontalThickness),
bounds.maxY() - verticalThickness - box.styleRef().borderBottomWidth(),
@@ -1508,7 +1508,7 @@ PassRefPtrWillBeRawPtr<Scrollbar> PaintLayerScrollableArea::ScrollbarManager::cr
ScrollbarControlSize scrollbarSize = RegularScrollbar;
if (actualLayoutObject.styleRef().hasAppearance())
scrollbarSize = LayoutTheme::theme().scrollbarControlSizeForPart(actualLayoutObject.styleRef().appearance());
- scrollbar = Scrollbar::create(m_scrollableArea.get(), orientation, scrollbarSize);
+ scrollbar = Scrollbar::create(m_scrollableArea.get(), orientation, scrollbarSize, &m_scrollableArea->box().frame()->page()->chromeClient());
if (orientation == HorizontalScrollbar)
m_scrollableArea->didAddScrollbar(*scrollbar, HorizontalScrollbar);
else

Powered by Google App Engine
This is Rietveld 408576698