Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1560343002: Test and fix resynthesized function-typed parameters referring to type parameters. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Test and fix resynthesized function-typed parameters referring to type parameters. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/2a4d803b32566ec60e153f722a61fd858f11fa28

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M pkg/analyzer/lib/src/summary/resynthesize.dart View 5 chunks +12 lines, -13 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-06 00:38:53 UTC) #2
Brian Wilkerson
LGTM
4 years, 11 months ago (2016-01-06 15:10:28 UTC) #3
Paul Berry
4 years, 11 months ago (2016-01-06 15:50:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2a4d803b32566ec60e153f722a61fd858f11fa28 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698