Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1560233002: Add missing return statement to fix Windows builds (Closed)

Created:
4 years, 11 months ago by Cutch
Modified:
4 years, 11 months ago
Reviewers:
rmacnak, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add missing return statement to fix Windows builds BUG= Committed: https://github.com/dart-lang/sdk/commit/a3c0ec05b7431ea6bc4a4bd4bb6ef4afc3fe059d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/os_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
Cutch
TBR
4 years, 11 months ago (2016-01-05 21:17:17 UTC) #3
Cutch
Committed patchset #1 (id:1) manually as a3c0ec05b7431ea6bc4a4bd4bb6ef4afc3fe059d (presubmit successful).
4 years, 11 months ago (2016-01-05 21:17:25 UTC) #5
srdjan
4 years, 11 months ago (2016-01-05 21:18:30 UTC) #7
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698