Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 156023002: gm self-test: stop checking stdout and stderr (Closed)

Created:
6 years, 10 months ago by epoger
Modified:
6 years, 10 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

gm self-test: stop checking stdout and stderr BUG=skia:1568 NOTRY=True Committed: http://code.google.com/p/skia/source/detail?r=13324

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+-12 lines, -355 lines) Patch
D gm/tests/outputs/add-config-pdf/output-expected/command_line View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/add-config-pdf/output-expected/stderr View 0 chunks +-1 lines, --1 lines 0 comments Download
D gm/tests/outputs/add-config-pdf/output-expected/stdout View 1 chunk +0 lines, -21 lines 0 comments Download
D gm/tests/outputs/checksum-based-filenames/output-expected/command_line View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/checksum-based-filenames/output-expected/stderr View 0 chunks +-1 lines, --1 lines 0 comments Download
D gm/tests/outputs/checksum-based-filenames/output-expected/stdout View 1 chunk +0 lines, -20 lines 0 comments Download
D gm/tests/outputs/compared-against-different-pixels-images/output-expected/command_line View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/compared-against-different-pixels-images/output-expected/stderr View 1 chunk +0 lines, -2 lines 0 comments Download
D gm/tests/outputs/compared-against-different-pixels-images/output-expected/stdout View 1 chunk +0 lines, -20 lines 0 comments Download
D gm/tests/outputs/compared-against-different-pixels-json/output-expected/command_line View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/compared-against-different-pixels-json/output-expected/stderr View 0 chunks +-1 lines, --1 lines 0 comments Download
D gm/tests/outputs/compared-against-different-pixels-json/output-expected/stdout View 1 chunk +0 lines, -20 lines 0 comments Download
D gm/tests/outputs/compared-against-empty-dir/output-expected/command_line View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/compared-against-empty-dir/output-expected/stderr View 0 chunks +-1 lines, --1 lines 0 comments Download
D gm/tests/outputs/compared-against-empty-dir/output-expected/stdout View 1 chunk +0 lines, -21 lines 0 comments Download
D gm/tests/outputs/compared-against-identical-bytes-images/output-expected/command_line View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/compared-against-identical-bytes-images/output-expected/stderr View 0 chunks +-1 lines, --1 lines 0 comments Download
D gm/tests/outputs/compared-against-identical-bytes-images/output-expected/stdout View 1 chunk +0 lines, -20 lines 0 comments Download
D gm/tests/outputs/compared-against-identical-bytes-json/output-expected/command_line View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/compared-against-identical-bytes-json/output-expected/stderr View 0 chunks +-1 lines, --1 lines 0 comments Download
D gm/tests/outputs/compared-against-identical-bytes-json/output-expected/stdout View 1 chunk +0 lines, -20 lines 0 comments Download
D gm/tests/outputs/compared-against-identical-pixels-images/output-expected/command_line View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/compared-against-identical-pixels-images/output-expected/stderr View 0 chunks +-1 lines, --1 lines 0 comments Download
D gm/tests/outputs/compared-against-identical-pixels-images/output-expected/stdout View 1 chunk +0 lines, -20 lines 0 comments Download
D gm/tests/outputs/compared-against-identical-pixels-json/output-expected/command_line View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/compared-against-identical-pixels-json/output-expected/stderr View 0 chunks +-1 lines, --1 lines 0 comments Download
D gm/tests/outputs/compared-against-identical-pixels-json/output-expected/stdout View 1 chunk +0 lines, -20 lines 0 comments Download
D gm/tests/outputs/compared-against-nonexistent-dir/output-expected/command_line View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/compared-against-nonexistent-dir/output-expected/stderr View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/compared-against-nonexistent-dir/output-expected/stdout View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/ignore-expectations-mismatch/output-expected/command_line View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/ignore-expectations-mismatch/output-expected/stderr View 0 chunks +-1 lines, --1 lines 0 comments Download
D gm/tests/outputs/ignore-expectations-mismatch/output-expected/stdout View 1 chunk +0 lines, -20 lines 0 comments Download
D gm/tests/outputs/ignoring-one-test/output-expected/command_line View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/ignoring-one-test/output-expected/stderr View 0 chunks +-1 lines, --1 lines 0 comments Download
D gm/tests/outputs/ignoring-one-test/output-expected/stdout View 1 chunk +0 lines, -21 lines 0 comments Download
D gm/tests/outputs/ignoring-some-failures/output-expected/command_line View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/ignoring-some-failures/output-expected/stderr View 0 chunks +-1 lines, --1 lines 0 comments Download
D gm/tests/outputs/ignoring-some-failures/output-expected/stdout View 1 chunk +0 lines, -20 lines 0 comments Download
D gm/tests/outputs/intentionally-skipped-tests/output-expected/command_line View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/intentionally-skipped-tests/output-expected/stderr View 0 chunks +-1 lines, --1 lines 0 comments Download
D gm/tests/outputs/intentionally-skipped-tests/output-expected/stdout View 1 chunk +0 lines, -20 lines 0 comments Download
D gm/tests/outputs/no-hierarchy/output-expected/command_line View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/no-hierarchy/output-expected/stderr View 0 chunks +-1 lines, --1 lines 0 comments Download
D gm/tests/outputs/no-hierarchy/output-expected/stdout View 1 chunk +0 lines, -20 lines 0 comments Download
D gm/tests/outputs/no-readpath/output-expected/command_line View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/no-readpath/output-expected/stderr View 0 chunks +-1 lines, --1 lines 0 comments Download
D gm/tests/outputs/no-readpath/output-expected/stdout View 1 chunk +0 lines, -19 lines 0 comments Download
D gm/tests/outputs/nonverbose/output-expected/command_line View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/nonverbose/output-expected/stderr View 0 chunks +-1 lines, --1 lines 0 comments Download
D gm/tests/outputs/nonverbose/output-expected/stdout View 1 chunk +0 lines, -11 lines 0 comments Download
D gm/tests/outputs/pipe-playback-failure/output-expected/command_line View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/pipe-playback-failure/output-expected/stderr View 1 chunk +0 lines, -2 lines 0 comments Download
D gm/tests/outputs/pipe-playback-failure/output-expected/stdout View 1 chunk +0 lines, -20 lines 0 comments Download
M gm/tests/run.sh View 3 chunks +3 lines, -13 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
epoger
Ready for review at patchset 1. https://codereview.chromium.org/156023002/diff/1/gm/tests/run.sh File gm/tests/run.sh (right): https://codereview.chromium.org/156023002/diff/1/gm/tests/run.sh#newcode91 gm/tests/run.sh:91: $COMMAND This is ...
6 years, 10 months ago (2014-02-05 18:01:14 UTC) #1
bsalomon
lgtm!
6 years, 10 months ago (2014-02-05 18:28:13 UTC) #2
epoger
The CQ bit was checked by epoger@google.com
6 years, 10 months ago (2014-02-05 18:43:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/156023002/1
6 years, 10 months ago (2014-02-05 18:43:54 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 18:44:47 UTC) #5
Message was sent while issue was closed. 
Change committed as 13324

Powered by Google App Engine
This is Rietveld 408576698