Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1560223002: Add quick launcher for launching mojo apps from within mash (Closed)

Created:
4 years, 11 months ago by Ben Goodger (Google)
Modified:
4 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@launcher
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add quick launcher for launching mojo apps from within mash R=sky@chromium.org BUG= Committed: https://crrev.com/ae9770b4de6eedaf41b5e2ab1f7b9c6b7c0d2421 Cr-Commit-Position: refs/heads/master@{#367783}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 3

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -119 lines) Patch
M mash/BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download
M mash/example/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M mash/example/main/BUILD.gn View 1 1 chunk +0 lines, -33 lines 0 comments Download
D mash/example/main/main.cc View 1 1 chunk +0 lines, -12 lines 0 comments Download
D mash/example/main/main_application_delegate.h View 1 1 chunk +0 lines, -33 lines 0 comments Download
M mash/example/main/main_application_delegate.cc View 1 1 chunk +0 lines, -25 lines 0 comments Download
A + mash/quick_launch/BUILD.gn View 1 2 3 4 2 chunks +11 lines, -12 lines 0 comments Download
A mash/quick_launch/quick_launch.cc View 1 2 3 4 5 1 chunk +118 lines, -0 lines 0 comments Download
M mash/shell/shell_application_delegate.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M mash/shell/shell_application_delegate.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M ui/views/widget/widget.cc View 1 2 3 4 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Ben Goodger (Google)
4 years, 11 months ago (2016-01-05 23:17:28 UTC) #1
sky
https://codereview.chromium.org/1560223002/diff/20001/mash/quick_launch/quick_launch.cc File mash/quick_launch/quick_launch.cc (right): https://codereview.chromium.org/1560223002/diff/20001/mash/quick_launch/quick_launch.cc#newcode32 mash/quick_launch/quick_launch.cc:32: QuickLaunchUI(mojo::ApplicationImpl* app) nit: explicit https://codereview.chromium.org/1560223002/diff/20001/mash/quick_launch/quick_launch.cc#newcode69 mash/quick_launch/quick_launch.cc:69: base::TrimWhitespaceASCII(working, base::TRIM_ALL, &working); ...
4 years, 11 months ago (2016-01-05 23:33:56 UTC) #2
sky
LGTM
4 years, 11 months ago (2016-01-06 00:08:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1560223002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1560223002/80001
4 years, 11 months ago (2016-01-06 00:42:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/32591) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 11 months ago (2016-01-06 00:57:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1560223002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1560223002/100001
4 years, 11 months ago (2016-01-06 04:47:49 UTC) #11
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 11 months ago (2016-01-06 05:33:48 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 05:35:20 UTC) #14
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/ae9770b4de6eedaf41b5e2ab1f7b9c6b7c0d2421
Cr-Commit-Position: refs/heads/master@{#367783}

Powered by Google App Engine
This is Rietveld 408576698