Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 15602003: add SkLerpXfermode (Closed)

Created:
7 years, 7 months ago by reed1
Modified:
7 years, 7 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -10 lines) Patch
A gm/lerpmode.cpp View 1 1 chunk +64 lines, -0 lines 0 comments Download
M gyp/effects.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkColorPriv.h View 2 chunks +15 lines, -10 lines 0 comments Download
A include/effects/SkLerpXfermode.h View 1 chunk +46 lines, -0 lines 0 comments Download
A src/effects/SkLerpXfermode.cpp View 1 chunk +110 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
reed1
should we write the gpu backend now or later
7 years, 7 months ago (2013-05-21 20:02:03 UTC) #1
bsalomon
lgtm with minor nit. If you want to take a crack at the gpu version, ...
7 years, 7 months ago (2013-05-21 20:27:11 UTC) #2
reed1
Committed patchset #2 manually as r9229 (presubmit successful).
7 years, 7 months ago (2013-05-21 21:33:20 UTC) #3
Justin Novosad
My 2 cents: I find "Lerp" is a very hacky name. I think this should ...
7 years, 7 months ago (2013-05-22 14:13:37 UTC) #4
reed1
7 years, 7 months ago (2013-05-22 14:22:09 UTC) #5
Message was sent while issue was closed.
On 2013/05/22 14:13:37, junov wrote:
> My 2 cents: I find "Lerp" is a very hacky name. I think this should be called
> "LinearBlend" and the parameter should be called "blendFactor". Other terms
that
> are often used to describe this effect in compositing jargon are "Crossfade"
and
> "Dissolve" (except in photoshop where dissolve means something else).
> 
> Also, in GLES2 this can be expressed as a blendFunc by setting the constant
> alpha and using the blend coefficients constant_alpha and
> one_minus_contant_alpha.  With this in mind, I wonder if there would be any
> value in adding support for constant color/alpha values in SkXfermode,
allowing
> this blend mode to be expressed using coefficients...

As a graphics API, I don't find lerp or bilerp out-of-bounds for a name (we use
bilerp publicly in GrTextureAccess.h), but if there is a consensus for a
different name, I'm fine w/ that too.

As for how best to communicate this to ganesh, I defer to that team.

Powered by Google App Engine
This is Rietveld 408576698