Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1560163002: [promise] revert error message change for Promise.resolve() (Closed)

Created:
4 years, 11 months ago by caitp (gmail)
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promise] revert error message change for Promise.resolve() Previously, it was `ToString(PromiseCast)`, which comes out as "function resolve() { [native code] }". I had changed it to "Promise.resolve()", but the other style is more consistently used. LOG=N R=cbruni@chromium.org, adamk@chromium.org, littledan@chromium.org Committed: https://crrev.com/5fcfe05a3b0d3d14575cf6fe112335442381bd33 Cr-Commit-Position: refs/heads/master@{#33129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/js/promise.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
caitp (gmail)
just undoes a small part of an earlier fix. I originally thought the updated error ...
4 years, 11 months ago (2016-01-05 21:23:05 UTC) #1
adamk
Can you add info about the message change to the CL description? That'd help me ...
4 years, 11 months ago (2016-01-05 21:28:09 UTC) #2
caitp (gmail)
On 2016/01/05 21:28:09, adamk wrote: > Can you add info about the message change to ...
4 years, 11 months ago (2016-01-05 21:29:35 UTC) #3
caitp (gmail)
On 2016/01/05 21:29:35, caitp wrote: > On 2016/01/05 21:28:09, adamk wrote: > > Can you ...
4 years, 11 months ago (2016-01-05 21:29:57 UTC) #4
adamk
lgtm I added your explanation to the CL description.
4 years, 11 months ago (2016-01-05 21:30:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1560163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1560163002/1
4 years, 11 months ago (2016-01-05 21:32:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 22:19:50 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 22:20:45 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5fcfe05a3b0d3d14575cf6fe112335442381bd33
Cr-Commit-Position: refs/heads/master@{#33129}

Powered by Google App Engine
This is Rietveld 408576698