Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: components/mus/ws/focus_controller.h

Issue 1560063003: mus: Fix activation cycle direction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tot.merge Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/mus/ws/focus_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/mus/ws/focus_controller.h
diff --git a/components/mus/ws/focus_controller.h b/components/mus/ws/focus_controller.h
index a86c86e3912ad44114cf3ee65ff1b1ecdcecf8bd..113a1cba62cc29d61cedb38bb45e40a8871f4e1f 100644
--- a/components/mus/ws/focus_controller.h
+++ b/components/mus/ws/focus_controller.h
@@ -9,6 +9,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/observer_list.h"
#include "components/mus/ws/server_window_drawn_tracker_observer.h"
+#include "components/mus/ws/server_window_tracker.h"
namespace mus {
@@ -18,6 +19,7 @@ class FocusControllerDelegate;
class FocusControllerObserver;
class ServerWindow;
class ServerWindowDrawnTracker;
+struct WindowId;
// Describes the source of the change.
enum class FocusControllerChangeSource {
@@ -44,7 +46,13 @@ class FocusController : public ServerWindowDrawnTrackerObserver {
void RemoveObserver(FocusControllerObserver* observer);
private:
- void SetActiveWindow(ServerWindow* window);
+ enum class ActivationChangeReason {
+ UNKNONW,
+ CYCLE, // Activation changed because of ActivateNextWindow().
+ FOCUS, // Focus change required a different window to be activated.
+ DRAWN_STATE_CHANGED, // Active window was hidden or destroyed.
+ };
+ void SetActiveWindow(ServerWindow* window, ActivationChangeReason reason);
// Returns whether |window| can be focused or activated.
bool CanBeFocused(ServerWindow* window) const;
@@ -71,6 +79,13 @@ class FocusController : public ServerWindowDrawnTrackerObserver {
ServerWindow* root_;
ServerWindow* focused_window_;
ServerWindow* active_window_;
+ // Tracks what caused |active_window_| to be activated.
+ ActivationChangeReason activation_reason_;
+
+ // Keeps track of the list of windows that have already been visited during a
+ // window cycle. This is only active when |activation_reason_| is set to
+ // CYCLE.
+ scoped_ptr<ServerWindowTracker> cycle_windows_;
base::ObserverList<FocusControllerObserver> observers_;
« no previous file with comments | « no previous file | components/mus/ws/focus_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698