Don't launch a new AsyncTask to log internal storage size

Don't launch a new AsyncTask to log internal storage size

UpdateMenuItemHelper#recordInternalStorageSize() is called from an
AsyncTask, so there is no need to start a new AsyncTask in that method.

BUG=566085
Committed: https://crrev.com/ce8f49a4280751bfff314b799239f131acfe99c2
Cr-Commit-Position: refs/heads/master@{#367417}

[Theresa, 2016-01-04 22:02:57]

twellington@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Theresa, 2016-01-04 22:02:57]

dfalcantara@ ptal

[gone, 2016-01-04 22:40:23]

lgtm

https://codereview.chromium.org/1560013002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java
(right):

https://codereview.chromium.org/1560013002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java:327:
private void recordInternalStorageSize() {
assert !ThreadUtils.runningOnUiThread()?

[Theresa, 2016-01-04 23:12:57]

https://codereview.chromium.org/1560013002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java
(right):

https://codereview.chromium.org/1560013002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java:327:
private void recordInternalStorageSize() {
On 2016/01/04 22:40:23, dfalcantara wrote:
> assert !ThreadUtils.runningOnUiThread()?

Done.

[Theresa, 2016-01-04 23:13:00]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2016-01-04 23:13:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1560013002/#ps20001
(title: "Add assert !ThreadUtils.runningOnUiThread();")

[commit-bot: I haz the power, 2016-01-04 23:14:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1560013002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1560013002/20001

[commit-bot: I haz the power, 2016-01-04 23:55:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-04 23:57:16]

Description was changed from

==========
Don't launch a new AsyncTask to log internal storage size

UpdateMenuItemHelper#recordInternalStorageSize() is called from an
AsyncTask, so there is no need to start a new AsyncTask in that method.

BUG=566085
==========

to

==========
Don't launch a new AsyncTask to log internal storage size

UpdateMenuItemHelper#recordInternalStorageSize() is called from an
AsyncTask, so there is no need to start a new AsyncTask in that method.

BUG=566085

Committed: https://crrev.com/ce8f49a4280751bfff314b799239f131acfe99c2
Cr-Commit-Position: refs/heads/master@{#367417}
==========

[commit-bot: I haz the power, 2016-01-04 23:57:17]

Patchset 2 (id:??) landed as
https://crrev.com/ce8f49a4280751bfff314b799239f131acfe99c2
Cr-Commit-Position: refs/heads/master@{#367417}