Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1560013002: Don't launch a new AsyncTask to log internal storage size (Closed)

Created:
4 years, 11 months ago by Theresa
Modified:
4 years, 11 months ago
Reviewers:
gone
CC:
chromium-reviews, Yaron
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't launch a new AsyncTask to log internal storage size UpdateMenuItemHelper#recordInternalStorageSize() is called from an AsyncTask, so there is no need to start a new AsyncTask in that method. BUG=566085 Committed: https://crrev.com/ce8f49a4280751bfff314b799239f131acfe99c2 Cr-Commit-Position: refs/heads/master@{#367417}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add assert !ThreadUtils.runningOnUiThread(); #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -16 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java View 1 1 chunk +12 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Theresa
dfalcantara@ ptal
4 years, 11 months ago (2016-01-04 22:02:57 UTC) #2
gone
lgtm https://codereview.chromium.org/1560013002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java File chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java (right): https://codereview.chromium.org/1560013002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java#newcode327 chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java:327: private void recordInternalStorageSize() { assert !ThreadUtils.runningOnUiThread()?
4 years, 11 months ago (2016-01-04 22:40:23 UTC) #3
Theresa
https://codereview.chromium.org/1560013002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java File chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java (right): https://codereview.chromium.org/1560013002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java#newcode327 chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java:327: private void recordInternalStorageSize() { On 2016/01/04 22:40:23, dfalcantara wrote: ...
4 years, 11 months ago (2016-01-04 23:12:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1560013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1560013002/20001
4 years, 11 months ago (2016-01-04 23:14:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-04 23:55:22 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 23:57:17 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ce8f49a4280751bfff314b799239f131acfe99c2
Cr-Commit-Position: refs/heads/master@{#367417}

Powered by Google App Engine
This is Rietveld 408576698