Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 15600003: Remove SkImageFilter::getInputResult(), since its return value is not (Closed)

Created:
7 years, 7 months ago by Stephen White
Modified:
7 years, 7 months ago
Reviewers:
reed, robertphillips, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove SkImageFilter::getInputResult(), since its return value is not style-compliant, and doesn't allow us to abort on failure. R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=9245 Committed: https://code.google.com/p/skia/source/detail?r=9274

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -26 lines) Patch
M include/core/SkImageFilter.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M src/effects/SkBicubicImageFilter.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +9 lines, -2 lines 0 comments Download
M src/effects/SkOffsetImageFilter.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Stephen White
reed: PTAL. Thanks!
7 years, 7 months ago (2013-05-21 21:40:19 UTC) #1
reed1
lgtm
7 years, 7 months ago (2013-05-21 21:55:06 UTC) #2
Stephen White
Committed patchset #1 manually as r9245 (presubmit successful).
7 years, 7 months ago (2013-05-22 19:00:07 UTC) #3
robertphillips
I reverted this in r9250 since Chrome relies on the getInputResult entry point. Specifically WebKit/Source/core/platform/graphics/filters/DropShadowImageFilter.cpp:65:26 ...
7 years, 7 months ago (2013-05-22 23:58:47 UTC) #4
Stephen White
On 2013/05/22 23:58:47, robertphillips wrote: > I reverted this in r9250 since Chrome relies on ...
7 years, 7 months ago (2013-05-23 00:55:02 UTC) #5
Stephen White
On 2013/05/23 00:55:02, Stephen White wrote: > On 2013/05/22 23:58:47, robertphillips wrote: > > I ...
7 years, 7 months ago (2013-05-23 01:30:18 UTC) #6
Stephen White
7 years, 7 months ago (2013-05-24 15:16:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r9274 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698