Remove unnecessary tear down logic from the zygote.

Remove unnecessary tear down logic from the zygote.

This CL removes the function TearDownAfterLastChild, because it appears
to be unnecessary. The zygote cleans up its children once it receives
an EOF on it's IPC socket, so once the Browser exits, so will the zygote.

BUG=569191
Committed: https://crrev.com/81a34db5d38e52941eedafdc2762f408fccba410
Cr-Commit-Position: refs/heads/master@{#367385}

[Greg K, 2016-01-04 20:31:06]

Description was changed from

==========
Remove unnecessary tear down logic from the zygote.

This CL removes the function TearDownAfterLastChild, because it appears
to be unnecessary. The zygote cleans up its children once it receives
an EOF on it's IPC socket, so once the Browser exits, so will the zygote.

BUG=569191
==========

to

==========
Remove unnecessary tear down logic from the zygote.

This CL removes the function TearDownAfterLastChild, because it appears
to be unnecessary. The zygote cleans up its children once it receives
an EOF on it's IPC socket, so once the Browser exits, so will the zygote.

BUG=569191
==========

[Greg K, 2016-01-04 20:31:06]

kerrnel@chromium.org changed reviewers:
+ mdempsky@chromium.org

[Greg K, 2016-01-04 20:31:51]

Matt, please review this change to delete TearDownAfterLastChild in a smaller CL
per your suggestion.

[mdempsky, 2016-01-04 20:51:39]

LGTM

I'd suggest you further prune this CL down to just the browser_main_loop.cc
change though.  There's no harm in leaving an unused non-virtual member function
around for a little longer.

[Greg K, 2016-01-04 21:00:49]

kerrnel@chromium.org changed reviewers:
+ avi@chromium.org

[Greg K, 2016-01-04 21:00:53]

avi@chromium.org: Please review changes in

[Avi (use Gerrit), 2016-01-04 21:49:20]

I don't know the zygote code at all. I will LGTM as an owner, but I'm trusting
mdempsky's expertise here.

[mdempsky, 2016-01-04 21:59:03]

On 2016/01/04 21:49:20, Avi wrote:
> I don't know the zygote code at all. I will LGTM as an owner, but I'm trusting
> mdempsky's expertise here.

Basically this is just a hint from the browser process to the zygote that it's
shutting down.  It lets the zygote know that it can exit once all of the
renderers have shut down, but the browser doesn't actually care whether the
zygote exits or not, and the zygote will exit anyway once it sees the browser
process has exited (because its IPC channel will close).

So theoretically this CL means the zygote process might linger around for
slightly longer.  I don't expect that to be a problem in practice, but just in
case, I suggested kerrnel@ should submit it separately first in case any bizarre
failures arise.

[Greg K, 2016-01-04 22:13:04]

The CQ bit was checked by kerrnel@chromium.org

[Greg K, 2016-01-04 22:13:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
mdempsky@chromium.org
Link to the patchset: https://codereview.chromium.org/1559983002/#ps20001
(title: "Leave the function definition.")

[commit-bot: I haz the power, 2016-01-04 22:13:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1559983002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1559983002/20001

[commit-bot: I haz the power, 2016-01-04 22:20:07]

Description was changed from

==========
Remove unnecessary tear down logic from the zygote.

This CL removes the function TearDownAfterLastChild, because it appears
to be unnecessary. The zygote cleans up its children once it receives
an EOF on it's IPC socket, so once the Browser exits, so will the zygote.

BUG=569191
==========

to

==========
Remove unnecessary tear down logic from the zygote.

This CL removes the function TearDownAfterLastChild, because it appears
to be unnecessary. The zygote cleans up its children once it receives
an EOF on it's IPC socket, so once the Browser exits, so will the zygote.

BUG=569191
==========

[commit-bot: I haz the power, 2016-01-04 22:20:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-04 22:21:35]

Description was changed from

==========
Remove unnecessary tear down logic from the zygote.

This CL removes the function TearDownAfterLastChild, because it appears
to be unnecessary. The zygote cleans up its children once it receives
an EOF on it's IPC socket, so once the Browser exits, so will the zygote.

BUG=569191
==========

to

==========
Remove unnecessary tear down logic from the zygote.

This CL removes the function TearDownAfterLastChild, because it appears
to be unnecessary. The zygote cleans up its children once it receives
an EOF on it's IPC socket, so once the Browser exits, so will the zygote.

BUG=569191

Committed: https://crrev.com/81a34db5d38e52941eedafdc2762f408fccba410
Cr-Commit-Position: refs/heads/master@{#367385}
==========

[commit-bot: I haz the power, 2016-01-04 22:21:35]

Patchset 2 (id:??) landed as
https://crrev.com/81a34db5d38e52941eedafdc2762f408fccba410
Cr-Commit-Position: refs/heads/master@{#367385}