Issue 1559953002: Revert "js_runtime: streamline stringReplaceAllUnchecked"

Issue 1559953002: Revert "js_runtime: streamline stringReplaceAllUnchecked" (Closed)

Created:
4 years, 11 months ago by sra1

Modified:
4 years, 11 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "js_runtime: streamline stringReplaceAllUnchecked" I missed a use of the REGEXP in another file. I will recommit with the REGEXP replaced with a function. Committed: https://github.com/dart-lang/sdk/commit/0d23ec2f7a7f2c1b5a0250de6bdd6e48aeace42d

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -14 lines)			Patch
	M	sdk/lib/_internal/js_runtime/lib/string_helper.dart	View		2 chunks	+4 lines, -4 lines	0 comments	Download
	M	tests/corelib/string_replace_all_test.dart	View		1 chunk	+0 lines, -10 lines	0 comments	Download

Total messages: 5 (3 generated)

sra1

Committed patchset #1 (id:1) manually as 0d23ec2f7a7f2c1b5a0250de6bdd6e48aeace42d (presubmit successful).

4 years, 11 months ago (2016-01-04 17:29:39 UTC) #4

Message was sent while issue was closed.

LGTM.