Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1559943002: [test] Add ignition test set. (Closed)

Created:
4 years, 11 months ago by Michael Achenbach
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Add ignition test set. Add control for the ignition test suites. This will be followed by a change on the infra side that targets the ignition set instead of the hardcoded mjsunit. After that, cctest can be enabled in a separate CL. This CL already includes the logic for running cctest for ignition on swarming. BUG=v8:4280 LOG=N Committed: https://crrev.com/ee66506737dbf828669857ec4422c26ff2bb3e01 Cr-Commit-Position: refs/heads/master@{#33089}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M build/all.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
A + test/ignition.gyp View 2 chunks +3 lines, -5 lines 2 comments Download
A + test/ignition.isolate View 1 chunk +1 line, -3 lines 0 comments Download
M tools/run-tests.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Michael Achenbach
PTAL
4 years, 11 months ago (2016-01-04 16:12:40 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559943002/20001
4 years, 11 months ago (2016-01-04 16:12:56 UTC) #5
tandrii(chromium)
lgtm
4 years, 11 months ago (2016-01-04 16:13:32 UTC) #6
rmcilroy
https://codereview.chromium.org/1559943002/diff/20001/test/ignition.gyp File test/ignition.gyp (right): https://codereview.chromium.org/1559943002/diff/20001/test/ignition.gyp#newcode14 test/ignition.gyp:14: 'mjsunit/mjsunit.gyp:mjsunit_run', missing test262 or is this still tested via ...
4 years, 11 months ago (2016-01-04 16:15:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559943002/20001
4 years, 11 months ago (2016-01-04 16:47:53 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-04 17:26:29 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ee66506737dbf828669857ec4422c26ff2bb3e01 Cr-Commit-Position: refs/heads/master@{#33089}
4 years, 11 months ago (2016-01-04 17:26:53 UTC) #14
Michael Achenbach
4 years, 11 months ago (2016-01-05 09:30:11 UTC) #15
Message was sent while issue was closed.
https://codereview.chromium.org/1559943002/diff/20001/test/ignition.gyp
File test/ignition.gyp (right):

https://codereview.chromium.org/1559943002/diff/20001/test/ignition.gyp#newco...
test/ignition.gyp:14: 'mjsunit/mjsunit.gyp:mjsunit_run',
On 2016/01/04 16:15:55, rmcilroy wrote:
> missing test262 or is this still tested via a different mechanism?

That'll stay separate, since the testing variants bite each other a bit. I.e.
test262 has this additional strong/sloppy thing...

Powered by Google App Engine
This is Rietveld 408576698