Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 1559923006: fix hints from analyzer in analyzer (Closed)

Created:
4 years, 11 months ago by Jennifer Messerly
Modified:
4 years, 11 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M pkg/analyzer/lib/dart/element/element.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/element/member.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element_handle.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
This gets analyzer self-analyzing clean, at least in my IntelliJ (using a bleeding edge analyzer ...
4 years, 11 months ago (2016-01-05 22:25:32 UTC) #2
Paul Berry
lgtm, thanks!
4 years, 11 months ago (2016-01-05 22:59:02 UTC) #3
Jennifer Messerly
4 years, 11 months ago (2016-01-05 23:19:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e2fa77776ca8a861738aad6b7be80273a0241272 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698