Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5687)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1559903002: linux: Build third-party code with -Wunused-result. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 732f71aca18612ba8207512b5690e5004d8ab64d..6b86d5ec31a834421c9aa34b96a6b295339d3911 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -946,14 +946,6 @@ config("no_chromium_code") {
cflags += [ "-Wall" ]
}
- if (is_linux) {
- # Don't warn about ignoring the return value from e.g. close(). This is
- # off by default in some gccs but on by default in others. BSD systems do
- # not support this option, since they are usually using gcc 4.2.1, which
- # does not have this flag yet.
- cflags += [ "-Wno-unused-result" ]
- }
-
if (is_clang) {
cflags += [
# Lots of third-party libraries have unused variables. Instead of
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698