Fix Ash on Windows multi-monitor support and snap-view sizing.

Fix Ash on Windows multi-monitor support and snap-view sizing.

Plumb through window size events to the remote root window host.
Also add an initial sizing message to get Ash's initial state to be correct.

BUG=236379
TEST=Move Ash from one monitor to another with a different size, observe that things resize themselves correctly. Also, snap Ash, observe similar goodness.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201771

[cpu_(ooo_6.6-7.5), 2013-05-21 20:36:12]

lgtm

https://codereview.chromium.org/15599002/diff/3001/win8/metro_driver/chrome_a...
File win8/metro_driver/chrome_app_view_ash.cc (right):

https://codereview.chromium.org/15599002/diff/3001/win8/metro_driver/chrome_a...
win8/metro_driver/chrome_app_view_ash.cc:835: args->get_Size(&size);
check the error code of get_Size. I guess don't send the message on error.

[robertshield, 2013-05-22 17:31:20]

+Scott for OWNERS on remote_root_window_host_win.*
+Chris for OWNERS on metro_viewer_messages.h

https://codereview.chromium.org/15599002/diff/3001/win8/metro_driver/chrome_a...
File win8/metro_driver/chrome_app_view_ash.cc (right):

https://codereview.chromium.org/15599002/diff/3001/win8/metro_driver/chrome_a...
win8/metro_driver/chrome_app_view_ash.cc:835: args->get_Size(&size);
On 2013/05/21 20:36:12, cpu wrote:
> check the error code of get_Size. I guess don't send the message on error.

Done.

[Chris Evans, 2013-05-22 19:22:56]

On 2013/05/22 17:31:20, robertshield wrote:
> +Scott for OWNERS on remote_root_window_host_win.*
> +Chris for OWNERS on metro_viewer_messages.h
> 
>
https://codereview.chromium.org/15599002/diff/3001/win8/metro_driver/chrome_a...
> File win8/metro_driver/chrome_app_view_ash.cc (right):
> 
>
https://codereview.chromium.org/15599002/diff/3001/win8/metro_driver/chrome_a...
> win8/metro_driver/chrome_app_view_ash.cc:835: args->get_Size(&size);
> On 2013/05/21 20:36:12, cpu wrote:
> > check the error code of get_Size. I guess don't send the message on error.
> 
> Done.

Thanks. Can you state which process type is sending this new message to which
other process type? It wasn't immediately obvious to me.

[robertshield, 2013-05-22 19:34:50]

On 2013/05/22 19:22:56, Chris Evans wrote:
> On 2013/05/22 17:31:20, robertshield wrote:
> > +Scott for OWNERS on remote_root_window_host_win.*
> > +Chris for OWNERS on metro_viewer_messages.h
> > 
> >
>
https://codereview.chromium.org/15599002/diff/3001/win8/metro_driver/chrome_a...
> > File win8/metro_driver/chrome_app_view_ash.cc (right):
> > 
> >
>
https://codereview.chromium.org/15599002/diff/3001/win8/metro_driver/chrome_a...
> > win8/metro_driver/chrome_app_view_ash.cc:835: args->get_Size(&size);
> > On 2013/05/21 20:36:12, cpu wrote:
> > > check the error code of get_Size. I guess don't send the message on error.
> > 
> > Done.
> 
> Thanks. Can you state which process type is sending this new message to which
> other process type? It wasn't immediately obvious to me.

I made the comment a bit clearer. What say you?

[Chris Evans, 2013-05-22 19:41:50]

https://codereview.chromium.org/15599002/diff/16001/ui/metro_viewer/metro_vie...
File ui/metro_viewer/metro_viewer_messages.h (right):

https://codereview.chromium.org/15599002/diff/16001/ui/metro_viewer/metro_vie...
ui/metro_viewer/metro_viewer_messages.h:153: int32)   /* height */
Can we make these unsigned types? Unless we're planning to actually pass
negative values and assign some special meaning to that value?

[robertshield, 2013-05-22 20:14:52]

https://codereview.chromium.org/15599002/diff/16001/ui/metro_viewer/metro_vie...
File ui/metro_viewer/metro_viewer_messages.h (right):

https://codereview.chromium.org/15599002/diff/16001/ui/metro_viewer/metro_vie...
ui/metro_viewer/metro_viewer_messages.h:153: int32)   /* height */
On 2013/05/22 19:41:50, Chris Evans wrote:
> Can we make these unsigned types? Unless we're planning to actually pass
> negative values and assign some special meaning to that value?

Done.

[Chris Evans, 2013-05-22 21:05:05]

On 2013/05/22 20:14:52, robertshield wrote:
>
https://codereview.chromium.org/15599002/diff/16001/ui/metro_viewer/metro_vie...
> File ui/metro_viewer/metro_viewer_messages.h (right):
> 
>
https://codereview.chromium.org/15599002/diff/16001/ui/metro_viewer/metro_vie...
> ui/metro_viewer/metro_viewer_messages.h:153: int32)   /* height */
> On 2013/05/22 19:41:50, Chris Evans wrote:
> > Can we make these unsigned types? Unless we're planning to actually pass
> > negative values and assign some special meaning to that value?
> 
> Done.

LGTM. I wonder if the code will handle the situation gracefully where width and
height are both send as something crazy like 1,000,000 ?

[sky, 2013-05-22 21:52:30]

LGTM

[robertshield, 2013-05-22 21:52:45]

I tried it out and Chrome still renders correctly but doesn't seem to
handle input correctly. This should be akin to resizing the chrome window
to huge dimensions.
On May 22, 2013 5:05 PM, <cevans@chromium.org> wrote:

> On 2013/05/22 20:14:52, robertshield wrote:
>
> https://codereview.chromium.**org/15599002/diff/16001/ui/**
>
metro_viewer/metro_viewer_**messages.h<https://codereview.chromium.org/15599002/diff/16001/ui/metro_viewer/metro_viewer_messages.h>
>
>> File ui/metro_viewer/metro_viewer_**messages.h (right):
>>
>
>
> https://codereview.chromium.**org/15599002/diff/16001/ui/**
>
metro_viewer/metro_viewer_**messages.h#newcode153<https://codereview.chromium.org/15599002/diff/16001/ui/metro_viewer/metro_viewer_messages.h#newcode153>
>
>> ui/metro_viewer/metro_viewer_**messages.h:153: int32)   /* height */
>> On 2013/05/22 19:41:50, Chris Evans wrote:
>> > Can we make these unsigned types? Unless we're planning to actually pass
>> > negative values and assign some special meaning to that value?
>>
>
>  Done.
>>
>
> LGTM. I wonder if the code will handle the situation gracefully where
> width and
> height are both send as something crazy like 1,000,000 ?
>
>
https://codereview.chromium.**org/15599002/<https://codereview.chromium.org/1...
>

[commit-bot: I haz the power, 2013-05-23 03:58:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/15599002/22001

[commit-bot: I haz the power, 2013-05-23 12:57:30]

Change committed as 201771