[SkDebugger] Display run glyph positioning modes

[SkDebugger] Display run glyph positioning modes

R=robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1559883002

Committed: https://skia.googlesource.com/skia/+/0d48e4175a69fb6c50ca19f0891558ff829a753d

[f(malita), 2016-01-04 14:58:34]

Description was changed from

==========
[SkDebugger] Display run glyph positioning modes

R=robertphillips@google.com
==========

to

==========
[SkDebugger] Display run glyph positioning modes

R=robertphillips@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[f(malita), 2016-01-04 15:06:23]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-04 15:06:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1559883002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1559883002/1

[commit-bot: I haz the power, 2016-01-04 15:22:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-04 15:22:26]

Dry run: This issue passed the CQ dry run.

[robertphillips1, 2016-01-04 15:49:51]

robertphillips@chromium.org changed reviewers:
+ robertphillips@chromium.org

[robertphillips1, 2016-01-04 15:49:52]

lgtm

https://codereview.chromium.org/1559883002/diff/1/src/utils/debugger/SkDrawCo...
File src/utils/debugger/SkDrawCommand.cpp (right):

https://codereview.chromium.org/1559883002/diff/1/src/utils/debugger/SkDrawCo...
src/utils/debugger/SkDrawCommand.cpp:702: while (!iter.done()) {
Maybe rename 'label' to 'tmpStr' ?

[f(malita), 2016-01-04 15:51:48]

https://codereview.chromium.org/1559883002/diff/1/src/utils/debugger/SkDrawCo...
File src/utils/debugger/SkDrawCommand.cpp (right):

https://codereview.chromium.org/1559883002/diff/1/src/utils/debugger/SkDrawCo...
src/utils/debugger/SkDrawCommand.cpp:702: while (!iter.done()) {
On 2016/01/04 15:49:52, robertphillips1 wrote:
> Maybe rename 'label' to 'tmpStr' ?

Done.

[f(malita), 2016-01-04 15:51:54]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2016-01-04 15:51:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@chromium.org
Link to the patchset: https://codereview.chromium.org/1559883002/#ps20001
(title: "review comments")

[commit-bot: I haz the power, 2016-01-04 15:52:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1559883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1559883002/20001

[commit-bot: I haz the power, 2016-01-04 16:08:06]

Description was changed from

==========
[SkDebugger] Display run glyph positioning modes

R=robertphillips@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
[SkDebugger] Display run glyph positioning modes

R=robertphillips@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/0d48e4175a69fb6c50ca19f0891558ff829a753d
==========

[commit-bot: I haz the power, 2016-01-04 16:08:07]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0d48e4175a69fb6c50ca19f0891558ff829a753d