Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1559873005: dbus: Use randomly generated string as a TestService's service name (Closed)

Created:
4 years, 11 months ago by hashimoto
Modified:
4 years, 11 months ago
Reviewers:
satorux1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

dbus: Use randomly generated string as a TestService's service name To run tests parallelly. BUG=571274 TEST=dbus_unittests Committed: https://crrev.com/067d84f52f2ec47c2614108be6bf0e11552eb34b Cr-Commit-Position: refs/heads/master@{#367499}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -32 lines) Patch
M dbus/end_to_end_async_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M dbus/end_to_end_sync_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M dbus/object_manager_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M dbus/object_proxy_unittest.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M dbus/property_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M dbus/signal_sender_verification_unittest.cc View 6 chunks +10 lines, -6 lines 0 comments Download
M dbus/test_service.h View 3 chunks +9 lines, -0 lines 0 comments Download
M dbus/test_service.cc View 7 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
hashimoto
4 years, 11 months ago (2016-01-05 08:12:41 UTC) #4
satorux1
lgtm
4 years, 11 months ago (2016-01-05 08:18:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559873005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559873005/20001
4 years, 11 months ago (2016-01-05 08:40:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 11 months ago (2016-01-05 08:48:10 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 08:48:55 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/067d84f52f2ec47c2614108be6bf0e11552eb34b
Cr-Commit-Position: refs/heads/master@{#367499}

Powered by Google App Engine
This is Rietveld 408576698