Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1559853002: [turbofan] Use NumberConstant for LoadElement's index (Closed)

Created:
4 years, 11 months ago by sigurds
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use NumberConstant for LoadElement's index LoadElement nodes used a Int32Constant in some cases, which made matching for constant values in optimizations more difficult than necessary. R=bmeurer@chromium.org Committed: https://crrev.com/72ddee79c3d85555d133eca2e991fedf33be26cd Cr-Commit-Position: refs/heads/master@{#33081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sigurds
PTAL
4 years, 11 months ago (2016-01-04 13:01:40 UTC) #1
Benedikt Meurer
LGTM.
4 years, 11 months ago (2016-01-04 13:02:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559853002/1
4 years, 11 months ago (2016-01-04 13:06:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-04 13:18:40 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 13:19:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72ddee79c3d85555d133eca2e991fedf33be26cd
Cr-Commit-Position: refs/heads/master@{#33081}

Powered by Google App Engine
This is Rietveld 408576698