Fix DOM Isolate affinity for interceptors

Fix DOM Isolate affinity for interceptors

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32629

[sra1, 2014-02-12 02:45:49]

The native interceptor dispatch was intended to work for multiple DOM isolates
loaded into one JavaScript context but became broken.

We need a test to stop that happening again :-)  I'm still working on that.  I
have not yet figured out how to run a d8 test with two inputs.  I will add that
when I get it figured out but the actual fix is P0 for a customer.

[floitsch, 2014-02-12 10:38:24]

LGTM.

https://codereview.chromium.org/155983004/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart
(right):

https://codereview.chromium.org/155983004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:995:
js('property = intern(rootProperty + "_" + i + "_")'),
Isn't generateDispatchPropertyName supposed to do that?
Otherwise, why does it have a seed?

https://codereview.chromium.org/155983004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:997:
js('usedProperties[property] = 1'),
That line seems to be important :)

[floitsch, 2014-02-12 15:33:38]

https://codereview.chromium.org/155983004/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart
(right):

https://codereview.chromium.org/155983004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:991:
'(Object[tableProperty] = Object.create(null))'),
We could also just store the counter of the last used name.

[sra1, 2014-02-12 22:01:20]

https://codereview.chromium.org/155983004/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart
(right):

https://codereview.chromium.org/155983004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:991:
'(Object[tableProperty] = Object.create(null))'),
On 2014/02/12 15:33:39, floitsch wrote:
> We could also just store the counter of the last used name.

Not if every program has an MD5-like root property to make clashes unlikely.

https://codereview.chromium.org/155983004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:995:
js('property = intern(rootProperty + "_" + i + "_")'),
On 2014/02/12 10:38:25, floitsch wrote:
> Isn't generateDispatchPropertyName supposed to do that?
> Otherwise, why does it have a seed?

The seed was for when I was generating a list of names.

There used to be a getter function created with 'new Function'.  The CSP version
had a list of explicit functions generated with different seeds at compile-time.
The MD5 root would mean in practice that the clashes only happen for multiple
instances of the same program, requiring a less deep stack of explicit
functions.

I'm removing the seed at this point.
It might get added back switch back to using a compiled getter using direct
property syntax instead of a "a[b]".

[sra1, 2014-02-12 22:07:50]

Committed patchset #4 manually as r32629 (presubmit successful).