Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: sandbox/src/sandbox_nt_util.cc

Issue 155979: Fix a FORWARD_NULL defect in ExtractModuleName reported by Coverity.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Upload before checkin Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/src/sandbox_nt_util.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/src/sandbox_nt_util.cc
===================================================================
--- sandbox/src/sandbox_nt_util.cc (revision 21299)
+++ sandbox/src/sandbox_nt_util.cc (working copy)
@@ -301,7 +301,6 @@
if (headers->OptionalHeader.SizeOfCode)
*flags |= MODULE_HAS_CODE;
}
-
} while (false);
} __except(EXCEPTION_EXECUTE_HANDLER) {
}
@@ -349,7 +348,7 @@
int start_pos = module_path->Length / sizeof(wchar_t) - 1;
int ix = start_pos;
- for(; ix >= 0; --ix) {
+ for (; ix >= 0; --ix) {
if (module_path->Buffer[ix] == L'\\') {
sep = &module_path->Buffer[ix];
break;
@@ -361,7 +360,7 @@
return NULL;
// No path separator found. Use the entire name.
- if ((ix == 0) && !sep) {
+ if (!sep) {
sep = &module_path->Buffer[-1];
}
« no previous file with comments | « sandbox/src/sandbox_nt_util.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698