Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1559783002: Fix -Wunused-function warnings in chrome/ios builds. (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
borenet, reed2, mtklein_C
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/core/SkOpts.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Nico
4 years, 11 months ago (2016-01-03 04:05:39 UTC) #3
mtklein_C
lgtm Is this an iOS emulator build?
4 years, 11 months ago (2016-01-03 20:28:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559783002/1
4 years, 11 months ago (2016-01-03 20:28:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/2d0e37a16eaf1281ace3e4034bf143853c236940
4 years, 11 months ago (2016-01-03 20:44:49 UTC) #8
Nico
On 2016/01/03 20:28:02, mtklein_C wrote: > lgtm > > Is this an iOS emulator build? ...
4 years, 11 months ago (2016-01-03 20:50:57 UTC) #9
reed2
we should try to get a bot that builds that, so we don't regress
4 years, 11 months ago (2016-01-04 01:45:49 UTC) #11
Nico
(there's a bot for this on the chromium waterfall which will make sure this doesn't ...
4 years, 11 months ago (2016-01-04 01:59:54 UTC) #12
mtklein
4 years, 11 months ago (2016-01-05 03:00:19 UTC) #13
Message was sent while issue was closed.
On 2016/01/04 01:45:49, reed2 wrote:
> we should try to get a bot that builds that, so we don't regress

It's nice to have the Chrome bots, but I agree it'd be nice to have a quick Skia
bot too.  An iOS emulator builder bot should be no big deal.  I bet Stephan's
the man for the job.

Powered by Google App Engine
This is Rietveld 408576698