Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2323)

Unified Diff: examples/ui/tile/tile_app.cc

Issue 1559723002: Update the UI examples. (Closed) Base URL: git@github.com:domokit/mojo.git@moz-14
Patch Set: address feedback Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « examples/ui/tile/tile_app.h ('k') | examples/ui/tile/tile_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: examples/ui/tile/tile_app.cc
diff --git a/examples/ui/tile/tile_app.cc b/examples/ui/tile/tile_app.cc
index 3360e1c0a88fdbbdf1d90527d12b5b3ea6a16ed5..2f5d4a41454473adce6134c6758a882a81a4e4da 100644
--- a/examples/ui/tile/tile_app.cc
+++ b/examples/ui/tile/tile_app.cc
@@ -11,55 +11,27 @@
namespace examples {
-class TileViewProvider : public mojo::ui::ViewProvider {
- public:
- TileViewProvider(mojo::ApplicationImpl* app_impl,
- const std::vector<std::string>& view_urls)
- : app_impl_(app_impl), view_urls_(view_urls) {}
- ~TileViewProvider() override {}
-
- private:
- // |ViewProvider|:
- void CreateView(mojo::InterfaceRequest<mojo::ServiceProvider> services,
- mojo::ServiceProviderPtr exposed_services,
- const CreateViewCallback& callback) override {
- new TileView(app_impl_, view_urls_, callback);
- }
-
- mojo::ApplicationImpl* app_impl_;
- std::vector<std::string> view_urls_;
-
- DISALLOW_COPY_AND_ASSIGN(TileViewProvider);
-};
-
TileApp::TileApp() {}
TileApp::~TileApp() {}
-void TileApp::Initialize(mojo::ApplicationImpl* app_impl) {
- app_impl_ = app_impl;
-}
-
-bool TileApp::ConfigureIncomingConnection(
- mojo::ApplicationConnection* connection) {
- connection->AddService<mojo::ui::ViewProvider>(this);
- return true;
-}
-
-void TileApp::Create(mojo::ApplicationConnection* connection,
- mojo::InterfaceRequest<mojo::ui::ViewProvider> request) {
- GURL url(connection->GetConnectionURL());
+bool TileApp::CreateView(
+ const std::string& connection_url,
+ mojo::InterfaceRequest<mojo::ServiceProvider> services,
+ mojo::ServiceProviderPtr exposed_services,
+ const mojo::ui::ViewProvider::CreateViewCallback& callback) {
+ GURL url(connection_url);
std::vector<std::string> view_urls;
base::SplitString(url.query(), ',', &view_urls);
if (view_urls.empty()) {
LOG(ERROR) << "Must supply comma-delimited URLs of mojo views to tile as a "
"query parameter.";
- return;
+ return false;
}
- bindings_.AddBinding(new TileViewProvider(app_impl_, view_urls),
- request.Pass());
+ new TileView(app_impl(), view_urls, callback);
+ return true;
}
} // namespace examples
« no previous file with comments | « examples/ui/tile/tile_app.h ('k') | examples/ui/tile/tile_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698