Issue 155972: Strip embedded "#" in URLs when constructing HTTP cache key....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155972: Strip embedded "#" in URLs when constructing HTTP cache key.... (Closed)

Created:
11 years, 5 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Strip embedded "#" in URLs when constructing HTTP cache key. BUG=http://crbug.com/17493 TEST=HttpCache.UrlContainingHash Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21408

Patch Set 2 : Fix a typo from past change #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -5 lines)			Patch
	M	net/http/http_cache.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
	M	net/http/http_cache_unittest.cc	View	1	3 chunks	+26 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

eroman

http://codereview.chromium.org/155972/diff/1/3 File net/http/http_cache.cc (left): http://codereview.chromium.org/155972/diff/1/3#oldcode1475 Line 1475: url.erase(url.find_last_of('#')); the issue here is that reverse-find doesn't ...

11 years, 5 months ago (2009-07-23 01:00:11 UTC) #1

LGTM++

Expand Messages | Collapse Messages

Issue 155972: Strip embedded "#" in URLs when constructing HTTP cache key.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix a typo from past change #

Messages