Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1559713002: Remove a "temporary" hack from when ChromeOS generated PDFs with Cairo. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
jam
CC:
chromium-reviews, sanjeevr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a "temporary" hack from when ChromeOS generated PDFs with Cairo. Committed: https://crrev.com/233d4015bcc12929ef089890cd376fd821d878d5 Cr-Commit-Position: refs/heads/master@{#367351}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -16 lines) Patch
M pdf/pdfium/pdfium_engine.cc View 1 chunk +3 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Lei Zhang
This temporary hack was added in https://chromereviews.googleplex.com/1660028 because 5 years ago Linux/ChromeOS was using Cairo ...
4 years, 11 months ago (2015-12-31 19:53:27 UTC) #2
jam
lgtm
4 years, 11 months ago (2016-01-04 15:44:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559713002/1
4 years, 11 months ago (2016-01-04 19:09:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-04 20:00:54 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 20:03:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/233d4015bcc12929ef089890cd376fd821d878d5
Cr-Commit-Position: refs/heads/master@{#367351}

Powered by Google App Engine
This is Rietveld 408576698