Chromium Code Reviews Chromium Code Reviews
Issue
155971:
Linux: Select omnibox text on button release instead of press. (Closed)
DescriptionLinux: Select omnibox text on button release instead of press.
We also don't select all of the text if the user dragged to
highlight some text before releasing the button.
Tested by repeating the scenarios from:
http://codereview.chromium.org/151006
http://codereview.chromium.org/159185
plus checking that the following cases behave as expected:
1. Type some text into the omnibox. Click in Webkit to give
it the focus. Click once in the omnibox. All of its
text should be highlighted, and middle-clicking in
another window should show that the primary selection was
updated.
2. Click in the omnibox to clear its highlighted text and
click in Webkit again. Click in the omnibox again, but
this time drag to highlight some text before letting go
of the button. The highlighted text should be preserved
on button release, and the primary selection should be
updated.
3. Repeat step 2. Click a few times in the omnibox and
confirm that we don't select all of its text (that should
only happen at the end of the initial click that focuses
the omnibox).
Patch Set 1 #
Messages
Total messages: 5 (0 generated)
|
||||||||||||||||||||||||||||
