Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1559703002: PDF: Fix another case of circular references with bookmarks. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PDF: Fix another case of circular references with bookmarks. BUG=512790 Committed: https://crrev.com/c2ebf3d0092b8bf990b9be0ac1a4cf547503d934 Cr-Commit-Position: refs/heads/master@{#367386}

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M pdf/pdfium/pdfium_engine.cc View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Lei Zhang
4 years, 11 months ago (2015-12-31 09:45:50 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1559703002/diff/1/pdf/pdfium/pdfium_engine.cc File pdf/pdfium/pdfium_engine.cc (right): https://codereview.chromium.org/1559703002/diff/1/pdf/pdfium/pdfium_engine.cc#newcode441 pdf/pdfium/pdfium_engine.cc:441: child_bookmark != nullptr; nit: just child_bookmark;
4 years, 11 months ago (2016-01-04 18:59:22 UTC) #3
Lei Zhang
https://codereview.chromium.org/1559703002/diff/1/pdf/pdfium/pdfium_engine.cc File pdf/pdfium/pdfium_engine.cc (right): https://codereview.chromium.org/1559703002/diff/1/pdf/pdfium/pdfium_engine.cc#newcode441 pdf/pdfium/pdfium_engine.cc:441: child_bookmark != nullptr; On 2016/01/04 18:59:22, Tom Sepez wrote: ...
4 years, 11 months ago (2016-01-04 21:44:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559703002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559703002/40001
4 years, 11 months ago (2016-01-04 21:45:56 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-04 22:25:41 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 22:26:45 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/c2ebf3d0092b8bf990b9be0ac1a4cf547503d934
Cr-Commit-Position: refs/heads/master@{#367386}

Powered by Google App Engine
This is Rietveld 408576698