Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1559693002: X87: [runtime] TailCallRuntime and CallRuntime should use default argument counts specified in runt… (Closed)

Created:
4 years, 11 months ago by zhengxing.li
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [runtime] TailCallRuntime and CallRuntime should use default argument counts specified in runtime.h. port b889d79de1e9af4719228536c736351c5680f25e(r33066) original commit message: In the vast majority of the cases when we call into the runtime we use the default number of arguments. Hence, there is not need to specify it again. This CL also removes TailCallExternalReference as there were no users. BUG= Committed: https://crrev.com/3d6f79bcb0309b6f43873d0138d69aabd06366a6 Cr-Commit-Position: refs/heads/master@{#33070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -25 lines) Patch
M src/x87/macro-assembler-x87.h View 1 chunk +12 lines, -11 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +21 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, Thanks!
4 years, 11 months ago (2015-12-31 07:15:06 UTC) #2
Weiliang
lgtm
4 years, 11 months ago (2015-12-31 07:45:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559693002/1
4 years, 11 months ago (2015-12-31 07:46:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-31 08:35:25 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2015-12-31 08:35:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d6f79bcb0309b6f43873d0138d69aabd06366a6
Cr-Commit-Position: refs/heads/master@{#33070}

Powered by Google App Engine
This is Rietveld 408576698