Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 155956: Provide direction when using gcl to not forget certain commit descriptions... (Closed)

Created:
11 years, 5 months ago by Mohamed Mansour
Modified:
9 years, 6 months ago
Reviewers:
jam, M-A Ruel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Provide direction when using gcl to not forget certain commit descriptions This patch follows what mal stated which is comment #2 on the bug tracker. BUG= http://crbug.com/17471 TEST= Ran "gcl change foo" and it added more direction within in the change description.

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M gcl.py View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Mohamed Mansour
11 years, 5 months ago (2009-07-22 22:55:14 UTC) #1
jam
have you actually tested this?
11 years, 5 months ago (2009-07-22 22:58:12 UTC) #2
Mohamed Mansour
On 2009/07/22 22:58:12, John Abd-El-Malek wrote: > have you actually tested this? Yes I have, ...
11 years, 5 months ago (2009-07-22 23:03:41 UTC) #3
M-A Ruel
I'm unsure about this since this is a lot of text to remove on each ...
11 years, 5 months ago (2009-07-23 00:06:22 UTC) #4
M-A Ruel
What I mean is that it'd be nice if it would act like git where ...
11 years, 5 months ago (2009-07-23 00:07:41 UTC) #5
jam
I'm not sure that this is the model that we settled on. I personally would ...
11 years, 5 months ago (2009-07-23 00:22:19 UTC) #6
M-A Ruel
11 years, 4 months ago (2009-08-06 15:32:43 UTC) #7
On 2009/07/23 00:22:19, John Abd-El-Malek wrote:
> I'm not sure that this is the model that we settled on.
> I personally would prefer that this template be shown once on issue
> creation, and the user can choose to use it or remove it.  But as is, it's
> shown each time, even when the user has already added this info!

I agree with John, can you show this only on new changelist?

Powered by Google App Engine
This is Rietveld 408576698