Issue 155954: Implement sending actions back to the render for media element context menus.

Issue 155954: Implement sending actions back to the render for media element context menus. (Closed)

Created:
11 years, 5 months ago by awong

Modified:
9 years, 7 months ago

Reviewers:
abarth-chromium, Alpha Left Google

CC:
chromium-reviews_googlegroups.com, fbarchard, scherkus (not reviewing), kylep

Visibility:
Public.

Description

Allow the browser to send actions back to the render for media element context menus. Also renamed ContextNodeType per fishd's suggestion. BUG=15686 TEST=none

Patch Set 1 #

Patch Set 2 : Moving to new implemnetaion based on redoing hittest #

Patch Set 3 : Rename ContextMenuAction and remove unimplemented menu items. #

Patch Set 4 : remove uneeded bits. #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+351 lines, -104 lines)			Patch
M	chrome/browser/renderer_host/render_view_host.h	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.h	View	1 2 3	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.cc	View	1 2	8 chunks	+110 lines, -29 lines	0 comments	Download
M	chrome/browser/views/tab_contents/render_view_context_menu_external_win.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/tab_contents/render_view_context_menu_win.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/render_messages.h	View	1 2	6 chunks	+52 lines, -12 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_view.h	View	1 2	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/renderer/render_view.cc	View	1 2	5 chunks	+13 lines, -2 lines	0 comments	Download
M	webkit/glue/context_menu.h	View	1 2	6 chunks	+37 lines, -13 lines	0 comments	Download
M	webkit/glue/context_menu_client_impl.cc	View	1 2 3	7 chunks	+39 lines, -36 lines	0 comments	Download
M	webkit/glue/glue_util.h	View		3 chunks	+6 lines, -0 lines	0 comments	Download
M	webkit/glue/glue_util.cc	View		3 chunks	+10 lines, -0 lines	0 comments	Download
M	webkit/glue/webview.h	View	2	2 chunks	+7 lines, -0 lines	0 comments	Download
M	webkit/glue/webview_delegate.h	View	1 2	3 chunks	+4 lines, -2 lines	0 comments	Download
M	webkit/glue/webview_impl.h	View	2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/glue/webview_impl.cc	View	2	2 chunks	+36 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.h	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

awong

11 years, 5 months ago (2009-07-23 23:07:57 UTC) #3

On 2009/07/23 22:12:13, Alpha wrote:
> LGTM.

Submitting with Alpha's LG.  Adam, if you have comments, you can still add them
and I'll open another CL.

Thanks,
Albert

Expand Messages | Collapse Messages