Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 1559473002: PPC: [runtime] Introduce dedicated JSBoundFunction to represent bound functions. (Closed)

Created:
4 years, 11 months ago by MTBrandyberry
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [runtime] Introduce dedicated JSBoundFunction to represent bound functions. Port 97def8070cbb979419c041c3732d5e11779f79da Original commit message: According to the ES2015 specification, bound functions are exotic objects, and thus don't need to be implemented as JSFunctions. So we introduce a new JSBoundFunction type to represent bound functions and make them optimizable. This already improves the performance of calling or constructing bound functions by 10-100x depending on the use case because we avoid the crazy dance between JavaScript and C++ that was implemented in v8natives.js previously. There's still room for improvement in the performance of actually creating bound functions, which is also relevant in practice, but we already have a plan how to accomplish that later. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:535408, chromium:571299, v8:4629 LOG=n Committed: https://crrev.com/974e50ba0d2150d8f8f74a88c03cea6e67897095 Cr-Commit-Position: refs/heads/master@{#33064}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -11 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 4 chunks +149 lines, -0 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559473002/1
4 years, 11 months ago (2015-12-30 14:41:46 UTC) #2
MTBrandyberry
4 years, 11 months ago (2015-12-30 14:48:27 UTC) #3
JoranSiu
On 2015/12/30 14:48:27, mtbrandyberry wrote: lgtm
4 years, 11 months ago (2015-12-30 16:00:34 UTC) #4
JoranSiu
On 2015/12/30 14:48:27, mtbrandyberry wrote: lgtm
4 years, 11 months ago (2015-12-30 16:00:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559473002/1
4 years, 11 months ago (2015-12-30 16:16:18 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_TIMED_OUT, no build URL)
4 years, 11 months ago (2015-12-30 16:41:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559473002/1
4 years, 11 months ago (2015-12-30 16:42:56 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-30 16:44:42 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 16:45:30 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/974e50ba0d2150d8f8f74a88c03cea6e67897095
Cr-Commit-Position: refs/heads/master@{#33064}

Powered by Google App Engine
This is Rietveld 408576698