Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1559443002: Diagnose failing GC transition on forced Oilpan GC. (Closed)

Created:
4 years, 11 months ago by sof
Modified:
4 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Diagnose failing GC transition on forced Oilpan GC. Temporary release asserts to help diagnose an unexpected&unsupported Blink GC transition. R=haraken BUG=571207 Committed: https://crrev.com/e3304b7e37091a909f9369a99cd2416ad2759854 Cr-Commit-Position: refs/heads/master@{#367150}

Patch Set 1 #

Patch Set 2 : comment reformat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look. Only reproducing w/ an android fuzzer build, not able to reproduce ...
4 years, 11 months ago (2015-12-30 10:58:40 UTC) #2
haraken
LGTM
4 years, 11 months ago (2015-12-30 11:40:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559443002/20001
4 years, 11 months ago (2015-12-30 12:22:29 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2015-12-30 12:35:51 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 12:37:10 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e3304b7e37091a909f9369a99cd2416ad2759854
Cr-Commit-Position: refs/heads/master@{#367150}

Powered by Google App Engine
This is Rietveld 408576698